Typo in MagpieRSS (deprecated)

[nithins53]

In wp-includes/rss.php, on line 198, 341 and 503 we can see typo errors.

Line 198- containging > containing

Line 341 descripton> description (typo in array key)

Line 503 habbit>habit

Trac ticket: https://core.trac.wordpress.org/ticket/57102

[desrosj]

The benefit of any updates to rss.php is becoming extremely low.

One thing to note is that changing the instance of $this->channel['descripton'] could result in unexpected behavior if someone using the class is checking for that index. While correcting the key's spelling would fix this bug, but would break those implementations.

Stepping back, I guess these are fine to make, but I'd honestly like to look at potentially being able to no-op this class entirely. MagpieRSS has been deprecated since WordPress 3.0, and a ​search of the plugin directory shows almost no real usage of the class (almost all of the matches are false positives or attempts to identify crawlers, which MagpieRSS is considered). I've opened #57107 to discuss this.

[anantajitjg]

Replying to desrosj:

The benefit of any updates to rss.php is becoming extremely low.

One thing to note is that changing the instance of $this->channel['descripton'] could result in unexpected behavior if someone using the class is checking for that index. While correcting the key's spelling would fix this bug, but would break those implementations.

Stepping back, I guess these are fine to make, but I'd honestly like to look at potentially being able to no-op this class entirely.

Completely agree with this. Looking forward to more updates from #57107.

[audrasjb]

Self assigning for commit.

[audrasjb]

In 55336:

Feeds: Fix various typos in MagpieRSS.

Props nithins53, desrosj, anantajitjg, mukesh27.
Fixes #57102.

committed in https://core.trac.wordpress.org/changeset/55336