Make WordPress Core

Opened 2 years ago

Last modified 3 months ago

#57127 new defect (bug)

Don't show links to the Customizer when installing themes

Reported by: dsas's profile dsas Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.1.1
Component: Themes Keywords:
Focuses: Cc:

Description

This is a follow-up to #54878. I think that issue solves the case when installing from the theme list, but not from the theme preview.

When installing a block theme I get a Live Preview link which opens the Customizer. The Customizer then has a link to Use Site Editor which opens the site editor with my current theme, not the one I just installed.

Repro steps

  1. Go to /wp-admin/theme-install.php?browse=block-themes
  2. Click one of the themes to launch the info/preview
  3. Click Install and wait for the installation to work
  4. Press the X at the top left to close the info/preview screen
  5. Click Live Preview on the recently installed theme

Change History (4)

#1 @dsas
2 years ago

Opened #57128 for the customizer specific 'Use Site Editor' bit

#2 @poena
4 months ago

  • Keywords reporter-feedback close added

Hi @dsas the Live Preview link no longer opens the Customizer for block themes. Are there any actionable items left in this ticket or can it be closed?

#3 @dsas
4 months ago

  • Keywords reporter-feedback removed

@poena sorry but Live Preview is still opening the Customizer on trunk (d6aa043) on the theme-install.php page for me. On themes.php the same theme is opening the Site Editor.

Here's a quick 20 second video: https://d.pr/v/cuiQnu

#4 @poena
3 months ago

  • Keywords close removed

I tested the same theme as you and I got the same result. But I can't get this notice to show with any other theme.
Evidently, the code for showing it is still in WordPress:
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/script-loader.php#L1340
https://github.com/WordPress/wordpress-develop/blob/trunk/src/js/_enqueues/wp/customize/controls.js#L8352

Note: See TracTickets for help on using tickets.