Make WordPress Core

Opened 17 months ago

Last modified 14 months ago

#57128 new defect (bug)

Customizer shows link to site editor when previewing themes

Reported by: dsas's profile dsas Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version: 5.9.3
Component: Customize Keywords: needs-design needs-patch
Focuses: Cc:

Description

#54878 removes the link to the customer from the theme installer in some cases, and #57127 will cover another, but if a user navigates directly to the customizer with a theme get var then they still get a confusing experience.

Repro steps:

  1. Activate a block theme e.g. twenty twenty-three
  2. Install an additional block theme but don't activate it
  3. Go to /wp-admin/customize.php?theme=loudness (where loudness is the slug of the installed but inactive block theme)
  4. Notice you are previewing the second, inactive theme.
  5. Get a notice saying 'Hurray! Your theme supports site editing with blocks. Tell me more. [ Use Site Editor]'
  6. Click Use Site Editor (goes to /wp-admin/site-editor.php?postType=wp_template&postId=twentytwentythree%2F%2Fhome)
  7. You will be editing the active theme and not the theme you were previewing

I expected to be editing the theme I was previewing.

Attachments (2)

new-message-for-inactive-block-themes.png (8.3 KB) - added by costdev 17 months ago.
New message for inactive block themes.
no-action-after-activating.gif (534.8 KB) - added by costdev 17 months ago.
Issue: No way to go to the Site Editor after activating.

Download all attachments as: .zip

Change History (9)

#1 @costdev
17 months ago

Hi @dsas, thanks for opening this ticket!

Pinging @antonvlasenko.

As the Site Editor can only be used with the active theme, I see a few options:

  • For block themes that aren't active, remove the Site Editor notice.
  • For block themes that aren't active, change the Site Editor notice to:

Hurray! Your theme supports site editing with blocks. Tell me more. [Activate this theme] to customize your site in the Site Editor.

Anton, I can have a patch ready for either of these quite quickly. Do you have a preference for one of the above options, or do you have any other ideas?

#2 @costdev
17 months ago

  • Version changed from 6.1.1 to 5.9

Updating the Version property to 5.9.3 when this notice was introduced in [53024].

#3 @costdev
17 months ago

  • Version changed from 5.9 to 5.9.3

#4 @antonvlasenko
17 months ago

@dsas
Great catch!
Thanks for reporting.

Hi @costdev,
I'd prefer to change the Site Editor notice (for block themes that aren't active).
Thanks.

Last edited 17 months ago by antonvlasenko (previous) (diff)

#5 @costdev
17 months ago

  • Keywords needs-design added
  • Milestone changed from Awaiting Review to 6.2

Working on this, here's what I have:

Message for active block themes

Hurray! Your theme supports site editing with blocks. Tell me more. [Use Site Editor]

Message for inactive block themes

Hurray! Your theme supports site editing with blocks. Tell me more. Activate your theme to customize your site in the Site Editor.

Just above this message is the Activate & Publish button, which is why I didn't include another button here.

However, upon clicking Activate & Publish, there is no way to go to the Site Editor from the screen.

  • Attaching a screenshot of the message, and a GIF of the issue.
  • Adding needs-design to get some help from the Design team.

@costdev
17 months ago

New message for inactive block themes.

@costdev
17 months ago

Issue: No way to go to the Site Editor after activating.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


14 months ago

#7 @mukesh27
14 months ago

  • Keywords needs-patch added
  • Milestone changed from 6.2 to Future Release

Thanks @dsas for the ticket.

This ticket was discussed during the recent bug scrub. It looks like it's unlikely that work will be done on this during the 6.2 cycle.

Moving to Future Release for now.

Note: See TracTickets for help on using tickets.