WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#57130 new defect (bug)

unittest for wp_upload_bits

Reported by: pbearne's profile pbearne Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: General Keywords: needs-testing has-patch has-unit-tests
Focuses: Cc:

Description


Change History (7)

This ticket was mentioned in ​PR #3659 on ​WordPress/wordpress-develop by ​@pbearne.
2 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/57130
This is isn't working maybe someone else can work why we get this error

1) tests_wp_upload_bits::test_second_parm_present
Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.

#2 @pbearne
2 years ago

  • Keywords needs-refresh needs-testing needs-unit-tests added; has-patch has-unit-tests removed

The linked pull request isn't working maybe someone else can work out why we get this error

1) tests_wp_upload_bits::test_second_parm_present
Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.

This ticket was mentioned in ​PR #3660 on ​WordPress/wordpress-develop by ​@pbearne.
2 years ago #3

  • Keywords has-patch has-unit-tests added; needs-refresh needs-unit-tests removed

Trac ticket: https://core.trac.wordpress.org/ticket/57130

​@spacedmonkey commented on ​PR #3660:
2 years ago #4

There were unit tests in the original PR - ​https://github.com/WordPress/wordpress-develop/pull/2367/files#diff-032b8ca66e0285a30919e60d55165db1e4ab54666b9012512f9e003ca9e07b84

I may have forgotten to commit these 😮‍💨

​@spacedmonkey commented on ​PR #3660:
2 years ago #5

There were unit tests in the original PR - ​https://github.com/WordPress/wordpress-develop/pull/2367/files#diff-032b8ca66e0285a30919e60d55165db1e4ab54666b9012512f9e003ca9e07b84

I may have forgotten to commit these 😮‍💨

@SergeyBiryukov

​@SergeyBiryukov commented on ​PR #3660:
2 years ago #6

Thanks for the PR!

It looks like there were some pre-existing tests for this function added in r52837 and moved to a separate file in r54861.

Keeping the ticket open for now to see if anything from this PR should be added to the existing tests (though at a glance it seems like they are mostly the same), as well as to commit ​some other tests pointed out above.

​@SergeyBiryukov commented on ​PR #3660:
2 years ago #7

I believe this is fixed as of r54861 and r54863.

Note: See TracTickets for help on using tickets.