WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 7 months ago

Last modified 2 months ago

#57130 closed defect (bug) (wontfix)

unittest for wp_upload_bits

Reported by: pbearne Owned by:
Priority: normal Milestone: Awaiting Review
Component: General Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description


Change History (10)

This ticket was mentioned in ​PR #3659 on ​WordPress/wordpress-develop by ​@pbearne.
4 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/57130
This is isn't working maybe someone else can work why we get this error

1) tests_wp_upload_bits::test_second_parm_present
Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.

#2 @pbearne
4 years ago

  • Keywords needs-refresh needs-testing needs-unit-tests added; has-patch has-unit-tests removed

The linked pull request isn't working maybe someone else can work out why we get this error

1) tests_wp_upload_bits::test_second_parm_present
Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.

This ticket was mentioned in ​PR #3660 on ​WordPress/wordpress-develop by ​@pbearne.
4 years ago #3

  • Keywords has-patch has-unit-tests added; needs-refresh needs-unit-tests removed

Trac ticket: https://core.trac.wordpress.org/ticket/57130

​@spacedmonkey commented on ​PR #3660:
4 years ago #4

There were unit tests in the original PR - ​https://github.com/WordPress/wordpress-develop/pull/2367/files#diff-032b8ca66e0285a30919e60d55165db1e4ab54666b9012512f9e003ca9e07b84

I may have forgotten to commit these 😮‍💨

​@spacedmonkey commented on ​PR #3660:
4 years ago #5

There were unit tests in the original PR - ​https://github.com/WordPress/wordpress-develop/pull/2367/files#diff-032b8ca66e0285a30919e60d55165db1e4ab54666b9012512f9e003ca9e07b84

I may have forgotten to commit these 😮‍💨

@SergeyBiryukov

​@SergeyBiryukov commented on ​PR #3660:
4 years ago #6

Thanks for the PR!

It looks like there were some pre-existing tests for this function added in r52837 and moved to a separate file in r54861.

Keeping the ticket open for now to see if anything from this PR should be added to the existing tests (though at a glance it seems like they are mostly the same), as well as to commit ​some other tests pointed out above.

​@SergeyBiryukov commented on ​PR #3660:
4 years ago #7

I believe this is fixed as of r54861 and r54863.

#8 @r1k0
7 months ago

  • Keywords needs-testing removed
  • Resolution → wontfix
  • Status new → closed

I believe this is fixed as of r54861 and r54863.

The tests needed are already available, as indicated above. Removing needs-testing, going ahead and closing (wontfix); the PR is closed in GitHub as well.

Last edited 7 months ago by r1k0 (previous) (diff)

​@mindctrl commented on ​PR #3659:
2 months ago #9

@pbearne if you're still working on this, could you bring it up to date with trunk? I'm unable to run the tests locally, I think due to some outdated Docker things still living in this branch.

​@pbearne commented on ​PR #3659:
2 months ago #10

@pbearne if you're still working on this, could you bring it up to date with trunk? I'm unable to run the tests locally, I think due to some outdated Docker things still living in this branch.

Refreshed

Note: See TracTickets for help on using tickets.