Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#57132 closed defect (bug) (reported-upstream)

Search placeholder not displaying on front-end

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.1.1
Component: Editor Keywords:
Focuses: ui Cc:

Description

While working with the Twenty Twenty-Three theme, I have checked that the Search block is look weired

The search block placeholder is displaying on back-end. But, its not working on front-end and not displaying.

Here, I have attached its screenshots

Attachments (4)

back-end.png (199.5 KB) - added by viralsampat 2 years ago.
front-end.png (119.7 KB) - added by viralsampat 2 years ago.
57132.patch (706 bytes) - added by viralsampat 2 years ago.
I have resolved the issue and added the patch.
after_added_custom_placeholder.png (86.3 KB) - added by viralsampat 2 years ago.
Added custom placeholder

Download all attachments as: .zip

Change History (8)

@viralsampat
2 years ago

@viralsampat
2 years ago

#1 @poena
2 years ago

Hi!

The placeholder text is optional. You need to add your own custom placeholder text, otherwise it will not show on the front.

If you add a custom text, does it not show on the front?

(The placeholder is opt-in because it is important for accessibility that the field does not include instructions. If someone adds instructions as the placeholder, then those instructions are removed when the user selects the field and starts typing. This can make the form difficult to use for people with cognitive problems or memory problems -or for anyone who is distracted.)

@viralsampat
2 years ago

I have resolved the issue and added the patch.

@viralsampat
2 years ago

Added custom placeholder

#2 @poena
2 years ago

I don't think "Optional placeholder..." would be a suitable text to show on the front of the website.

Changes to blocks should be made in the Gutenberg plugin first, so that it can be tested before it is included in WordPress core.

The first step to make that change, would be to open a new issue in the Gutenberg GitHub repository: https://github.com/WordPress/gutenberg

Last edited 2 years ago by poena (previous) (diff)

#3 @poena
2 years ago

  • Summary changed from Twenty Twenty-Three: Search placeholder not displaying on front-end to Search placeholder not displaying on front-end

#4 @sabernhardt
2 years ago

  • Component changed from General to Editor
  • Focuses accessibility removed
  • Keywords needs-patch needs-testing dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.