Make WordPress Core

Opened 2 years ago

Closed 9 months ago

#57135 closed enhancement (wontfix)

Twenty Twenty-Three: Adopt postTypes for header/footer patterns

Reported by: dsas's profile dsas Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.1
Component: Bundled Theme Keywords: close 2nd-opinion
Focuses: Cc:

Description

The Twenty Twenty-Three header and footer patterns are listed in the inserter when creating posts and pages, as well as when editing templates and template parts.

Is there a good reason for header and footer patterns to be available in the inserter when creating posts and pages?

Since 6.1 patterns can have postTypes which limits where a pattern can be used. Setting postTypes to ['wp_template', 'wp_template_part'] on header/footer patterns will mean that the patterns don't show up when editing pages/posts but will show up when editing templates and template parts. Currently the TT3 patterns don't use the postTypes property at all

Change History (4)

#1 @SergeyBiryukov
15 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from TT3: Adopt postTypes for header/footer patterns to Twenty Twenty-Three: Adopt postTypes for header/footer patterns

#2 @poena
10 months ago

  • Keywords close 2nd-opinion added

Hi @dsas

If I remember correctly, this was primarily so that users can use them with the blank page template.

WordPress also has default header and footer patterns that are available in the post editor.

Because of that, I suggest that this issue is closed.

#3 @dean
10 months ago

In that case it could be set to ['wp_template', 'wp_template_part', 'wp_page'], i.e. not posts but I don't feel strongly about this.

#4 @karmatosed
9 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

In this case, I also agree with @poena on closing. I am marking as 'won't fix' due to it not being something to consider later.

Note: See TracTickets for help on using tickets.