Opened 3 years ago
Last modified 10 days ago
#57141 new defect (bug)
WP_Theme cannot locate a parent block theme
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | 6.0 |
| Component: | Themes | Keywords: | has-patch needs-unit-tests needs-refresh |
| Focuses: | Cc: |
Description (last modified by )
As reported here: https://github.com/WordPress/gutenberg/issues/45811 after a discussion in slack: https://wordpress.slack.com/archives/C02QB8GMM/p1668569269811889
On wp-themes.com we're running into a use-case where the Parent theme cannot be located when both the parent and child theme are block themes, and the parent does not have an index.php file.
(See screenshot attached below, where the parent theme is 100% most definitely installed)
This appears to work on some installations, but not on others. I believe it working might be down to caching, I haven't figured that out.
The attached PR updates the code in WP_Theme to support the same theme files as supported via [53416] for themes in parent themes.
Attachments (1)
Change History (9)
This ticket was mentioned in PR #3646 on WordPress/wordpress-develop by @dd32.
3 years ago
#1
- Keywords has-patch added
#2
@
3 years ago
- Description modified (diff)
- Keywords needs-unit-tests needs-testing added
- Version set to 6.0
I'm not familiar enough with the rest of this code to really figure out if the PR is a complete solution, but it appears to work for me.
#3
@
3 years ago
Note: While https://github.com/WordPress/gutenberg/issues/45811 suggests that Gutenberg needs to be active to trigger the issue, I can duplicate the WP_Theme issues with or without it.
This ticket was mentioned in Slack in #core-themes by dd32. View the logs.
3 years ago
This ticket was mentioned in Slack in #meta by nosolosw. View the logs.
3 years ago
This ticket was mentioned in Slack in #meta by nosolosw. View the logs.
3 years ago
This ticket was mentioned in Slack in #meta by dd32. View the logs.
3 years ago
#8
@
10 days ago
- Keywords needs-refresh added; needs-testing removed
I attempted to apply the patch from the GitHub pull request https://github.com/WordPress/wordpress-develop/pull/3646 against current trunk (7.0-alpha), but it does not apply cleanly.
Patch results:
- src/wp-includes/class-wp-theme.php → 1 hunk failed (.rej created)
Since the patch cannot be applied, testing is not currently possible. Keeping needs-testing does not make sense until the patch is refreshed to match trunk.
Trac ticket: https://core.trac.wordpress.org/ticket/57141