#57143 closed defect (bug) (fixed)
Add escaping properly in Permalink options page
| Reported by: | jaedm97 | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.2 |
| Component: | Permalinks | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | administration |
Description
In the options-permalink.php, I noticed there are some missing escaping. I think these should be escaped properly. Example
<?php echo '%' . $tag . '%'; ?>
Here the variable $tag is not escaped while using.
Attachments (1)
Change History (11)
This ticket was mentioned in PR #3883 on WordPress/wordpress-develop by @audrasjb.
4 years ago
#4
Patch refresh for https://core.trac.wordpress.org/ticket/57143
#5
@
4 years ago
PR has passed all checks.
Searched options-permalink.php with the term echo
There were 10 occurances.
8 resolved after applying patch.
2 more occurances of echo $blog_prefix; which has static value /blog.
✅ Patch looks good to go for 6.2
#6
@
4 years ago
I’ve Re-checked the mentioned PR that @robinwpdeveloper checked.
Searched options-permalink.php with the term echo
There were 10 occurrences.
After applying the patch 8 occurrences are resolved and there are 2 more occurrences echo $blog_prefix
Screenshot: https://d.pr/i/rMUnsa
✅ Patch looks good for 6.2
@audrasjb commented on PR #3883:
4 years ago
#10
committed in https://core.trac.wordpress.org/changeset/55331
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Created patch.