Make WordPress Core

Opened 19 months ago

Last modified 17 months ago

#57145 new enhancement

Deactivate button "Copy site info to clipboard" until health check has completed

Reported by: pixolin's profile pixolin Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch 2nd-opinion
Focuses: ui Cc:

Description

In the (German) support forums we frequently ask people to provide more information about their website and refer to the button "Copy site info to clipboard" in Tools > Site Health > Info. Often users try to react immediately and spontanously click the button before the health check is completed and the status is shown above. This results in an incomplete report, showing the text "loading …" for the size of the entire website and some subdirectories. We are then missing an important piece of information to fully evaluate the website.

As an enhancement I kindly suggest that the button gets grayed out until the Health Check is completed.

Change History (9)

This ticket was mentioned in PR #3656 on WordPress/wordpress-develop by @riccardodicurti.


19 months ago
#1

  • Keywords has-patch added

In the (German) support forums we frequently ask people to provide more information about their website and refer to the button "Copy site info to clipboard" in Tools > Site Health > Info. Often users try to react immediately and spontanously click the button before the health check is completed and the status is shown above. This results in an incomplete report, showing the text "loading …" for the size of the entire website and some subdirectories. We are then missing an important piece of information to fully evaluate the website.

As an enhancement I kindly suggest that the button gets grayed out until the Health Check is completed.

Trac ticket: https://core.trac.wordpress.org/ticket/57145

#2 @riccardodicurti
19 months ago

  • Focuses ui added
  • Version set to trunk

#3 @SergeyBiryukov
19 months ago

  • Milestone changed from Awaiting Review to 6.2
  • Version changed from trunk to 5.2

Hi there, thanks for the ticket and the PR!

Introduced in [44986] / #46573, so 5.2 appears to be the earliest applicable version.

#4 @faguni22
17 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/3656.diff

Environment

  • OS: macOS 12.6
  • Web Server: Nginx
  • PHP: 7.4.33
  • WordPress: 6.2-alpha-54642-src
  • Browser: Safari 15.4
  • Theme: Twenty Twenty-Three
  • Active Plugins: No plugin is activated

Actual Results

  • ✅ Issue resolved with patch.

Additional Notes

  • I've tested the patch and found out that the button is disabled after applying the patch.

Supplemental Artifacts

Before: https://d.pr/i/zVEkdg
After: https://d.pr/i/ffxkBC
Screen cast: https://d.pr/v/7QtnyB

#5 @audrasjb
17 months ago

  • Keywords 2nd-opinion added

I see a potential issue with this patch: if for some reason the check can't finish (maybe if one test is running again and again), the copy button will stay disabled forever, even if it can actually provide some useful insights.

#6 @pixolin
17 months ago

Good point. How about an additional setTimeout() then?

This ticket was mentioned in Slack in #core by costdev. View the logs.


17 months ago

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


17 months ago

#9 @costdev
17 months ago

  • Milestone changed from 6.2 to Future Release

This ticket was discussed during the bug scrub. As this ticket still needs discussion and 6.2 Beta 1 is being released today, I'll move this to Future Release.

Additional props: @mukesh27

Note: See TracTickets for help on using tickets.