Deactivate button "Copy site info to clipboard" until health check has completed

[pixolin]

In the (German) support forums we frequently ask people to provide more information about their website and refer to the button "Copy site info to clipboard" in Tools > Site Health > Info. Often users try to react immediately and spontanously click the button before the health check is completed and the status is shown above. This results in an incomplete report, showing the text "loading …" for the size of the entire website and some subdirectories. We are then missing an important piece of information to fully evaluate the website.

As an enhancement I kindly suggest that the button gets grayed out until the Health Check is completed.

In the (German) support forums we frequently ask people to provide more information about their website and refer to the button "Copy site info to clipboard" in Tools > Site Health > Info. Often users try to react immediately and spontanously click the button before the health check is completed and the status is shown above. This results in an incomplete report, showing the text "loading …" for the size of the entire website and some subdirectories. We are then missing an important piece of information to fully evaluate the website.

As an enhancement I kindly suggest that the button gets grayed out until the Health Check is completed.

Trac ticket: https://core.trac.wordpress.org/ticket/57145

[SergeyBiryukov]

Hi there, thanks for the ticket and the PR!

Introduced in [44986] / #46573, so 5.2 appears to be the earliest applicable version.

[faguni22]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/3656.diff

Environment

• OS: macOS 12.6
• Web Server: Nginx
• PHP: 7.4.33
• WordPress: 6.2-alpha-54642-src
• Browser: Safari 15.4
• Theme: Twenty Twenty-Three
• Active Plugins: No plugin is activated

Actual Results

• ✅ Issue resolved with patch.

Additional Notes

• I've tested the patch and found out that the button is disabled after applying the patch.

Supplemental Artifacts

Before: ​https://d.pr/i/zVEkdg
After: ​https://d.pr/i/ffxkBC
Screen cast: ​https://d.pr/v/7QtnyB

[audrasjb]

I see a potential issue with this patch: if for some reason the check can't finish (maybe if one test is running again and again), the copy button will stay disabled forever, even if it can actually provide some useful insights.

[pixolin]

Good point. How about an additional setTimeout() then?

[costdev]

This ticket was discussed during the bug scrub. As this ticket still needs discussion and 6.2 Beta 1 is being released today, I'll move this to Future Release.

Additional props: @mukesh27