WordPress.org
Get WordPress

Make WordPress Core

Opened 22 months ago

Closed 19 months ago

Last modified 19 months ago

#57151 closed defect (bug) (fixed)

unittest for wp_check_filetype

Reported by: pbearne's profile pbearne Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description


Change History (11)

#1 @pbearne
22 months ago

  • Component changed from General to Build/Test Tools

This ticket was mentioned in ​PR #3648 on ​WordPress/wordpress-develop by ​@pbearne.
22 months ago #2

  • Keywords has-patch has-unit-tests added

Just tests

Trac ticket: [](https://core.trac.wordpress.org/ticket/57151)

#3 @costdev
22 months ago

  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to 6.2

This ticket was mentioned in ​PR #4158 on ​WordPress/wordpress-develop by ​@costdev.
19 months ago #4

Refreshes #3648.

This adds tests for wp_check_filetype(), and achieves 100% line and branch coverage.

https://i0.wp.com/user-images.githubusercontent.com/79332690/222239711-f85dd8c1-482f-4274-8740-9a12906af35f.png

Trac ticket: https://core.trac.wordpress.org/ticket/57151

#5 @costdev
19 months ago

  • Keywords changes-requested removed

​PR 4158 refreshes PR 3648 to improve compliance with standards, add a few extra datasets and improve existing dataset names.

This ticket was mentioned in ​Slack in #core by costdev. ​View the logs.
19 months ago

#7 @hellofromTonya
19 months ago

  • Owner set to hellofromTonya
  • Status changed from new to reviewing

Self-assigning for commit ready and prep.

#8 @hellofromTonya
19 months ago

  • Keywords commit added

Ready for commit. Will prep shortly.

#9 @hellofromTonya
19 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55456:

Build/Test Tools: Add wp_check_filetype() unit tests.

Adds a test class and data set for unit testing wp_check_filetype().

Props pbearne, costdev.
Fixes #57151.

Note: See TracTickets for help on using tickets.