Make WordPress Core

Opened 19 months ago

Last modified 2 months ago

#57154 new enhancement

Twenty Twenty-Three: Changing Size Preset from Button Typography is not affecting on front page "Get in Touch" button

Reported by: abidhasan112's profile abidhasan112 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.1.1
Component: Bundled Theme Keywords: has-patch dev-feedback
Focuses: Cc:

Description

  1. Go to Appearance > Editor > Styles(top right corner) > Typography > Buttons
  2. Change the values(ie. S, M, L, XL, XXL) from Size Preset
  3. Check the "Get in Touch" button from the left side preview. That's not affected by the size changes.

Here is the video as well: https://youtu.be/UcOcMcHGK9s

Thank you!

Attachments (1)

57154.diff (758 bytes) - added by sabernhardt 2 months ago.
resets font size for Button block in CTA pattern

Download all attachments as: .zip

Change History (6)

#1 @poena
19 months ago

Hi Abid!
Thank you for the report and the video.

Like you mentioned and illustrated in the video, the settings in the Styles sidebar in the Site Editor are defaults: If you add a new button, the updated font size will be used correctly.

If a button already has a font size set in the block settings sidebar or in a template or pattern, then that size is used instead of the default.

In Twenty Twenty-Three, the designer has chosen to use the small font size.
The font size is part of the markup:

<div class="wp-block-button has-custom-font-size has-small-font-size">
<a class="wp-block-button__link wp-element-button">Get In Touch</a></div>

To change the size, the individual block can be selected and the size changed in the block settings.
-This works the same for all block themes, and it is not limited to the font size setting.
Therefor, this is not a bug.

It would be great if we could come up with a better way to communicate this to users so that editing is less confusing.


If we want to remove the small font size from the button in Twenty Twenty-Three, then we need to remove the font size in this block pattern: call-to-action.php line 21 and 22

#2 @poena
19 months ago

  • Component changed from Themes to Bundled Theme
  • Type changed from defect (bug) to enhancement

#3 @SergeyBiryukov
15 months ago

  • Summary changed from Changing Size Preset from Button Typography is not affecting on Twenty Twenty-Three theme's front page "Get in Touch" button to Twenty Twenty-Three: Changing Size Preset from Button Typography is not affecting on front page "Get in Touch" button

@sabernhardt
2 months ago

resets font size for Button block in CTA pattern

#4 @sabernhardt
2 months ago

  • Focuses css removed
  • Keywords has-patch 2nd-opinion added; needs-patch removed

The Button block with the Small text option was added to the "Call to action" pattern in PR 61.

The difference between the Small and Medium text sizes is not much, though I am not convinced that the pattern should change. When using the CTA pattern, the Button block still needs at least the link reference to be useful, and the styles can be changed for that block (or else the "Buttons" block could be deleted and replaced with a new block that has default/global styling).

I have some interface concerns that make editing the styles less pleasant, but those are not related directly to the theme.

  • I needed to open the Typography options and choose "Reset All" to remove the font size from the pattern's block. Clicking the S did not undo the selection, which I expected because clicking a color selection removes the special color choice.
  • If I want to update the styles for a block within the pattern, I did not find an indication in the blog home template that the section was the CTA pattern (and that I would need to edit the pattern to affect any other place I might add it).

#5 @karmatosed
2 months ago

  • Keywords dev-feedback added; 2nd-opinion removed
Note: See TracTickets for help on using tickets.