Email change confirmation link incorrect for MU user with no roles

[roytanck]

The link in an email change confirmation email for users with no roles in a multisite install is incorrect, causing them to be unable to change their email address.

This appears to be a regression. The same issue was fixed in [38876] , but [41163] appears to have undone that fix.

Steps to reproduce:

• Create a new (subdirectory) multisite install.
• In the network admin, create a new user.
• Do not assign any roles to this user.
• Login as the new user, and attempt to change their email address.
• When clicking the link in the confirmation email, an error will appear.

As described in #38451, adding /user in the URL will fix the issue. It appears that self_admin_url() does this.

[johnbillion]

Thanks for the report

[SergeyBiryukov]

hi there, thanks for the ticket!

Indeed, it looks like [41163] accidentally reverted both [38876] and a part of [40632], however the latter was fixed in [41165], so self_admin_url() is the only thing to restore here.

[roytanck]

Use self_admin_url instead of admin_url when constructing the email confirmation URL.

[roytanck]

Added a patch that simply replaces admin_url with self_admin_url to restore the previous fix. This fixes the issue for me, but some regression testing is probably warranted.

[afrin29]

While trying to reproduce the issue;
unable to create a new multi-site user.
SS:https://d.pr/i/G3Jkqk

[johnbillion]

57164.diff​ fixes the issue as expected, but this is temporarily blocked by #38460 (the bug noted by @afrin29 above) which should be fixed first.

[audrasjb]

This is no longer blocked by #38460, fixed in [55394].

[audrasjb]

Self assigning for commit as John is AFK at the moment

[audrasjb]

In 55396:

Users: Fix confirmation link for multisite users with no role.

This fixes a regression introduced in [41163], where the link in change confirmation emails for users with no roles in a multisite install was incorrect, causing them to be unable to change their email address. This changeset replaces admin_url() with self_admin_url() to restore the previous fix.

Follow-up to [38876], [40632], [41165], [41163].

Props roytanck, SergeyBiryukov, johnbillion, afrin29.
Fixes #57164.