Make WordPress Core

Opened 2 years ago

Closed 11 months ago

Last modified 11 months ago

#57191 closed task (blessed) (fixed)

test for _delete_option_fresh_site

Reported by: pbearne's profile pbearne Owned by: swissspidy's profile swissspidy
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: Cc:

Description


Change History (6)

This ticket was mentioned in PR #3674 on WordPress/wordpress-develop by @pbearne.


2 years ago
#1

  • Keywords has-patch has-unit-tests added

@desrosj commented on PR #3674:


18 months ago
#2

Looking at this, why do we need to retrieve the option's value prior to checking? Can't we just use '0' instead since that should be the value?

@desrosj commented on PR #3674:


18 months ago
#3

Ah, I see the resolved conversation now. To make sure I understand, the concern is that the value is potentially not '0' when the test method starts, and if there is a failure, it won't be returned to the originally expected value

#4 @swissspidy
11 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 57729:

Build/Test Tools: Add unit tests for _delete_option_fresh_site().

Props pbearne, costdev, desrosj.
Fixes #57191.

#6 @swissspidy
11 months ago

  • Milestone changed from Awaiting Review to 6.5
  • Type changed from defect (bug) to task (blessed)
Note: See TracTickets for help on using tickets.