WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#57191 closed task (blessed) (fixed)

test for _delete_option_fresh_site

Reported by: pbearne Owned by: swissspidy
Priority: normal Milestone: 6.5
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description


Change History (6)

This ticket was mentioned in ​PR #3674 on ​WordPress/wordpress-develop by ​@pbearne.
4 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/57191

​@desrosj commented on ​PR #3674:
3 years ago #2

Looking at this, why do we need to retrieve the option's value prior to checking? Can't we just use '0' instead since that should be the value?

​@desrosj commented on ​PR #3674:
3 years ago #3

Ah, I see the resolved conversation now. To make sure I understand, the concern is that the value is potentially not '0' when the test method starts, and if there is a failure, it won't be returned to the originally expected value

#4 @swissspidy
2 years ago

  • Owner set to swissspidy
  • Resolution → fixed
  • Status new → closed

In 57729:

Build/Test Tools: Add unit tests for _delete_option_fresh_site().

Props pbearne, costdev, desrosj.
Fixes #57191.

#6 @swissspidy
2 years ago

  • Milestone Awaiting Review → 6.5
  • Type defect (bug) → task (blessed)
Note: See TracTickets for help on using tickets.