Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#57194 closed enhancement (fixed)

Alignment issue for the "No Plugins Found" search results.

Reported by: sruthi90's profile sruthi90 Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version: 6.1
Component: Plugins Keywords: has-patch has-screenshots commit
Focuses: css Cc:

Description

Found an alignment issue for plugin search results in the Plugins section of the Admin panel.

For finding the issue, please follow the below steps.

1.Go to Plugins section in Admin Panel and select Add New page.
2.Search some keyword which will output "No search Result", for example 'checkresults' in the search plugins input.
3.Message with alignment issue (aligned to the left side , should be shown in the centre) will be shown.

Attachments (3)

Screenshot 2022-11-24 at 1.38.57 PM.png (627.6 KB) - added by sruthi90 15 months ago.
57194.diff (409 bytes) - added by aparnajl 15 months ago.
This patch will center align the message like all other pages.
Screenshot 2022-11-24 at 8.00.18 PM.png (774.8 KB) - added by anantajitjg 15 months ago.
I have also checked the changes. Works well. Adding screenshot after applying the change as requested.

Download all attachments as: .zip

Change History (14)

@aparnajl
15 months ago

This patch will center align the message like all other pages.

#1 in reply to: ↑ description @sruthi90
15 months ago

Replying to sruthi90:

Typo

1.Go to Plugins section in Admin Panel and select Add New plugin.
2.Search some keyword which will output "No search Result", for example 'checkresults' in the search plugins input.
3.Message with alignment issue (aligned to the left side , should be shown in the centre) will be shown.

#2 @krupalpanchal
15 months ago

  • Component changed from General to Plugins
  • Keywords has-patch has-screenshots added; needs-patch removed

Hi @sruthi90

Welcome to core trac and thanks for reporting.

Looks like this happened because the below CSS is added.

.plugin-install-php #the-list {
    display: flex;
    flex-wrap: wrap;
}

It was not there in the previous version. But let's see team's review.

#3 @audrasjb
15 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 6.2
  • Owner set to audrasjb
  • Status changed from new to reviewing

Thanks for pointing this out, moving for 6.2 consideration.

Introduced in [54149].
See #55721, #55272.

#4 @audrasjb
15 months ago

  • Keywords changes-requested added; needs-testing removed

The patch works fine (thanks), but to avoid further conflicts, I'd rather add width: 100% to .no-plugin-results so we're sure we don't touch anything else than the No result behavior.

Last edited 15 months ago by audrasjb (previous) (diff)

#5 @sruthi90
15 months ago

Thanks for welcoming me.

Looking forward for updates regarding this issue.Also looking forward to contribute more to WordPress.

#7 @audrasjb
15 months ago

  • Keywords needs-testing added; changes-requested removed

The above pull request fixes the issue on my side. Anyone available to confirm and to add a before/after screenshot?

#8 @krupalpanchal
15 months ago

@audrasjb PR LGTM. Checked the changes on my side also. Works well.

@anantajitjg
15 months ago

I have also checked the changes. Works well. Adding screenshot after applying the change as requested.

#9 @audrasjb
15 months ago

  • Keywords commit added; needs-testing removed

Thanks friends. Marking for commit.

#10 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54871:

Plugins: Improve "No plugin found" message alignement in Plugins screen.

This changeset centers the "No plugin found" message in plugin search results.

Follow-up to [54149].

Props sruthi90, aparnajl, krupalpanchal, audrasjb, anantajitjg.
Fixes #57194.
See #55721, #55272.

Note: See TracTickets for help on using tickets.