WP_Customize_Manager::has_published_pages() fails when queried page is not top-level

[felipelavinz]

The Homepage Settings section on the customizer uses WP_Customize_Manager::has_published_pages() as active_callback.

Unfortunately, the changes introduced for bug #55425 lead to an error with the logical check, which is that when the queried page it's not top-level (post_parent = 0), get_pages() incorrectly returns an empty array.

This could be solved by adding 'hierarchical' => 0 to the get_pages() arguments.

Add hierarchical = 0 to the get_pages() call on WP_Customize_Manager::has_published_pages() so the check doesn't fail when the queried page is not top-level.

Trac ticket: https://core.trac.wordpress.org/ticket/57198

[dlh]

Welcome back to Trac, @felipelavinz, and thanks for the report!

I've been able to replicate this bug on a new installation using these steps:

1. Switch to the Twenty Twenty theme.
2. Publish the draft "Privacy Policy" page, and make it a child of "Sample Page"
3. Open the Customizer, and observe that the "Homepage Settings" section is missing.

The fix in the PR makes sense to me and works in my testing. Marking for 6.2 consideration.

[felipelavinz]

Thank you, I'm glad to help!

Let me know if there's anything else I can do, it would be great to have this fix for 6.2 :-)

[costdev]

Test Report

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/3680/

Steps to Reproduce or Test

1. Switch to the Twenty Twenty theme.
2. Publish the draft "Privacy Policy" page, and make it a child of "Sample Page".
3. 🐞 Navigate to Appearance > Customize.

Expected Results

When reproducing a bug:

• ❌ The "Homepage Settings" section should be missing.

When testing a patch to validate it works as expected:

• ✅ The "Homepage Settings" section should be available.

Environment

• Server: Apache (Linux)
• WordPress: 6.1.1
• Browser: Chrome 107.0.0.0
• OS: Windows 10
• Theme: Twenty Twenty
• Plugins: None activated

Actual Results

When reproducing a bug/defect:

• ❌ Issue reproduced. The "Homepage Settings" section is missing.

When testing the bugfix patch:

• ✅ Patch resolves the issue. The "Homepage Settings" section is available.

Notes

• The patch works as expected. Adding for commit consideration.

[audrasjb]

Thank for the patch @felipelavinz and for the test cases @dlh and @costdev ✌️
I can reproduce the error and the patch fixes the issue on my case.
Self assigning for commit.

[audrasjb]

In 54935:

Customize: Fix a wrong condition on WP_Customize_Manager::has_published_pages().

The Homepage Settings section on the customizer uses WP_Customize_Manager::has_published_pages() as active_callback. [53057] introduced an error on the logical check when the queried page is not a top-level page, which leads has_published_pages to incorrectly return an empty array.

This changeset fixes the issue by adding 'hierarchical' => 0 to get_pages() arguments.

Follow-up to [53057].

Props felipelavinz, dlh, costdev.
Fixes #57198.

committed in https://core.trac.wordpress.org/changeset/54935