#57208 closed enhancement (fixed)
Missing parameter comment
Reported by: | mahekkalola | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | good-first-bug has-patch commit |
Focuses: | docs | Cc: |
Description
Missing parameter comment for the below functions:
file path: src\wp-admin\includes\template.php
1) function name: wp_link_category_checklist( $link_id = 0 )
line number: 265
2) function name: wp_comment_reply( $position = 1, $checkbox = false, $mode = 'single', $table_row = true )
line number: 410
3) function name: list_meta( $meta )
line number: 570
4) function name: _list_meta_row( $entry, &$count )
line number: 616
5) function name: find_posts_div( $found_action = )
line number: 1974
Change History (13)
This ticket was mentioned in PR #3689 on WordPress/wordpress-develop by @riccardodicurti.
2 years ago
#2
- Keywords has-patch added
Added missing comment about parameters for some functions.
Trac ticket: https://core.trac.wordpress.org/ticket/57208
#3
@
2 years ago
- Keywords has-patch removed
Hi @mahekkalola, Hi @costdev,
I made a first change of the comments, if you need any further changes or additions let me know and I'll update the PR.
#5
@
2 years ago
- Keywords changes-requested added
Thanks @riccardodicurti! I've left a review on the PR. 🙂
#7
@
2 years ago
- Keywords changes-requested removed
Thanks @riccardodicurti! The PR looks good to me! 🙂
@audrasjb What do you think?
#10
@
2 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 6.2
Looks good to me. There is a small indentation issue but I'll fix it directly when committing the changeset :)
@audrasjb commented on PR #3689:
2 years ago
#12
Thanks everyone. Committed in https://core.trac.wordpress.org/changeset/54883
@audrasjb commented on PR #3689:
2 years ago
#13
Thanks everyone. Committed in https://core.trac.wordpress.org/changeset/54883
Hi @mahekkalola, welcome to Trac and thanks for opening this ticket!
Do you plan to submit a patch for this, or is this just a report?