Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 8 years ago

#5721 closed defect (bug) (fixed)

Future posts published with Windows Live Writer are scheduled for incorrect time.

Reported by: markjaquith's profile markjaquith Owned by: markjaquith's profile markjaquith
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3.2
Component: XML-RPC Keywords: has-patch
Focuses: Cc:

Description

WP GMT Offset: -05

  1. Compose post in Windows Live Writer
  2. Set publish time to 1 hour in the future
  3. Publish
  4. View "Manage > Posts" and verify that publish time is correct (it is).
  5. View "Dashboard" and note that pseudo cron has the post scheduled to "fire" in 6 hours.

Tried with a few other times, and it seems to be [Publish Time] - [GMT Offset].

Tried on WordPress.com and the post failed to publish (can't see the scheduled time on the dashboard).

I couldn't trigger this bug with MarsEdit (which uses a different API). I'm leaning towards this being a WLW bug, but it's strange that the publish time would be right but the cron time wouldn't.

This is also another reason why our pseudo cron implementation needs a re-work... you shouldn't be able to schedule a post to publish at any time other than its publish date!

Attachments (1)

date_created_gmt__TRUNK.diff (1.9 KB) - added by markjaquith 16 years ago.
For Trunk

Download all attachments as: .zip

Change History (8)

#1 @lloydbudd
16 years ago

  • Owner changed from anonymous to josephscott

#2 @lloydbudd
16 years ago

  • Owner changed from josephscott to markjaquith

Mark and Joseph discussed this on IRC #wordpress-hackers -- hopefully they summarize it here, but the conclusion is that Mark will work on a patch.

#3 @markjaquith
16 years ago

  • Keywords has-patch added
  • Milestone changed from 2.5 to 2.3.3
  • Status changed from new to assigned

Here's the issue:

Windows Live Writer sends dateCreated without the "Z" designating is as a GMT date. WordPress assumes it is a local time, and post_date_gmt gets offset (by the WP-stored GMT offset).

Two things need to happen:

  1. Windows Live Writer needs to send the "Z" so we know it's GMT
  2. We need to give preference to date_created_gmt (which we can reasonably assume to be GMT even if it lacks the "Z") over dateCreated

Joseph is in contact with the WLW people about the first part, and I've created a patch to do the second part.

#4 @lloydbudd
16 years ago

  • Milestone changed from 2.3.3 to 2.5

Generally, we leave Milestone as trunk, until after it has 1st been fixed and vented there.

#5 @josephscott
16 years ago

  • Cc josephscott added

#6 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6691]) Future post publishing over XML-RPC fixes from markjaquith. fixes #5721

This ticket was mentioned in Slack in #core by redsweater. View the logs.


8 years ago

Note: See TracTickets for help on using tickets.