WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#57210 closed defect (bug) (fixed)

Inconsistent function definition brace

Reported by: mukesh27's profile mukesh27 Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch good-first-bug
Focuses: coding-standards Cc:

Description

Related to #57209.

This is inconsistent because the function's right bracket is not present in the new line. The new line should contain the brace.

Change History (7)

This ticket was mentioned in ​PR #3688 on ​WordPress/wordpress-develop by ​@mukesh27.
2 years ago #1

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/57210

#2 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#3 @davidbaumwald
2 years ago

  • Keywords good-first-bug added

#4 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54881:

Coding Standards: Various brace indentation corrections.

Props mukesh27.
Fixes #57210.
See #56791.

#5 @audrasjb
2 years ago

Please note that I separated this patch in two commits. One for Core fixes, and one for Twentyten.

#7 @audrasjb
2 years ago

In 54882:

Twenty Ten: Fixes brace indentation in loop-attachment template.

Props mukesh27.
See #57210, #56791.

Note: See TracTickets for help on using tickets.