WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#57227 closed defect (bug) (fixed)

_prime_(comment|term|site)_caches() don't account for primed objects without primed meta

Reported by: ocean90 Owned by: spacedmonkey
Priority: normal Milestone: 6.3
Component: Options, Meta APIs Version:
Severity: normal Keywords: has-dev-note
Cc: Focuses: performance

Description

This is similar to #57163 where _prime_post_caches() was fixed.

Example for comments:

<?php
_prime_comment_caches( $comment_ids, false );
_prime_comment_caches( $comment_ids, true ); // Bug: No meta is primed

Change History (6)

#1 @spacedmonkey
3 years ago

  • Milestone Future Release → 6.3
  • Owner set to spacedmonkey
  • Status new → assigned

#2 @spacedmonkey
3 years ago

Now that #57645 was committed [55671]. This means that term meta is fixed. Comment meta will be fixed in #57801.

#3 @spacedmonkey
3 years ago

Added a ticket for site meta as well #58185.

#4 @spacedmonkey
3 years ago

  • Resolution → fixed
  • Status assigned → closed

This issue has been fixed as part of #57645 [55671], #57801 [55749] and #58185 [55747].

I am going to close this ticket out for now.

#5 @spacedmonkey
3 years ago

  • Keywords needs-dev-note added

#6 @spacedmonkey
3 years ago

  • Keywords has-dev-note added; needs-patch needs-dev-note removed

Dev note: ​https://make.wordpress.org/core/2023/07/13/improvements-to-the-metadata-api-in-wordpress-6-3/

Note: See TracTickets for help on using tickets.