#57230 closed enhancement (fixed)
Small typo in options.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Options, Meta APIs | Keywords: | has-patch commit |
Focuses: | ui-copy | Cc: |
Description
There is one sentence that doesn't work in wp-admin/options.php on line 248.
<strong>Error:</strong> Options page %s not found in the allowed options list.
I think we better add an "is" in there. To this:
<strong>Error:</strong> Options page %s is not found in the allowed options list.
Change History (11)
#1
@
2 years ago
- Component changed from General to Text Changes
- Type changed from defect (bug) to enhancement
This ticket was mentioned in PR #3708 on WordPress/wordpress-develop by @NekoJonez.
2 years ago
#2
- Keywords has-patch added
#3
follow-up:
↓ 5
@
2 years ago
- Keywords reporter-feedback added
Nicely spotted @NekoJonez!
The original sentence reads more like a note than a message:
Error: Options page %s not found in the allowed options list.
Your suggestion improves this:
Error: Options page %s is not found in the allowed options list.
However, I still think it reads a little like a note rather than a message.
Some things that jumped out at me when reading this:
- "is", or "was"? - The search is already complete.
- "not found" - This tells the user something about the process, rather than the result.
What do you think about this instead?
Error: The %s options page is not in the allowed options list.
This:
- Reflects the present state: It's not in the list.
- Doesn't add unnecessary information about the process.
- Reads like a message, rather than a note.
@NekoJonez commented on PR #3708:
2 years ago
#4
On the ticket, an even better string was suggested. So, let's implement that one!
#5
in reply to:
↑ 3
@
2 years ago
Replying to costdev:
Nicely spotted @NekoJonez!
The original sentence reads more like a note than a message:
Error: Options page %s not found in the allowed options list.
Your suggestion improves this:
Error: Options page %s is not found in the allowed options list.
However, I still think it reads a little like a note rather than a message.
Some things that jumped out at me when reading this:
- "is", or "was"? - The search is already complete.
- "not found" - This tells the user something about the process, rather than the result.
What do you think about this instead?
Error: The %s options page is not in the allowed options list.
This:
- Reflects the present state: It's not in the list.
- Doesn't add unnecessary information about the process.
- Reads like a message, rather than a note.
PR adjusted. :)
#6
@
2 years ago
- Keywords commit added; reporter-feedback removed
- Milestone changed from Awaiting Review to 6.2
#8
@
2 years ago
- Keywords commit removed
- Owner set to audrasjb
- Status changed from new to accepted
Looks good to me!
Marking for commit
.
@audrasjb commented on PR #3708:
2 years ago
#11
Committed in https://core.trac.wordpress.org/changeset/54926
There is a small typo in this page. I feel that a verb is missing on line 248. So, this is a fix.
https://core.trac.wordpress.org/ticket/57230