Missing ":" in strings with links.

[NekoJonez]

Personally, I think that strings with a link should have a ":". To separate the actual sentence with the link. There are a few places where this doesn't happen. In this ticket/PR I'm going to change that.

https://core.trac.wordpress.org/ticket/57231
Small fix for the above ticket.

[mukesh27]

Thanks @NekoJonez for the ticket and PR.

I find a similar instance in Core files; can you search see http in the whole directory and make the necessary changes?

[NekoJonez]

Replying to mukesh27:

Thanks @NekoJonez for the ticket and PR.

I find a similar instance in Core files; can you search see http in the whole directory and make the necessary changes?

I did it via translate.wp.org and searched that way... Is there a better way? Since it's the only one I was able to find.

[costdev]

Let's see how many instances there are in Core, and whether others agree with this proposal.

Personally, I don't have strong feelings one way or the other. However, it should be noted that if no colon is the prevaling format in Core, each string will need to be translated again if this change is introduced.

[costdev]

Performing a regex search on the codebase using ['"].+see http.+['"] seems to show this as the only instance in Core's user-facing strings.

[NekoJonez]

Replying to costdev:

Performing a regex search on the codebase using ['"].+see http.+['"] seems to show this as the only instance in Core's user-facing strings.

I haven't done that once in my life... :/ How do I go about doing that? Installing the Github client?

[costdev]

@NekoJonez I have the wordpress-develop git repository cloned locally, so I used VS Code's "Find in files" feature, ticked the .* symbol to enable regex and entered ['"].+see http.+['"]

[costdev]

@mukesh27 can you provide more detail on the results you found in other Core files?

[mukesh27]

@costdev You can please search See http in code base.

ex.
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-site-icon.php#L44
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-site-icon.php#L59
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-community-events.php#L400

[NekoJonez]

Replying to mukesh27:

@costdev You can please search See http in code base.

ex.
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-site-icon.php#L44
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-site-icon.php#L59
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-community-events.php#L400

Ahn, I see what's going on here and why I didn't see those... Those are in the docs. And those don't appear on translate.wp.org

I'll try to fix this, this weekend.

[costdev]

@mukesh27 Saw those too but thought we were only talking about changing user-facing strings. Happy to broaden the scope to all instances of See http, especially considering there are so few.

[NekoJonez]

Replying to costdev:

@mukesh27 Saw those too but thought we were only talking about changing user-facing strings. Happy to broaden the scope to all instances of See http, especially considering there are so few.

True, the search I did via VS Code gave me 290 results. All of them are either in comments OR in test flows. So, user facing strings... It's only those who appear on translate.wp.org and then my PR is for that string.

If wanted @mukesh27, I'm willing to make a new ticket for the ":" in the comments? Or should we make one ticket?

[mukesh27]

@NekoJonez Make sense. Left make another ticket that fixed the issue for the comments and test flows.

[cafenoirdesign]

A refresh of the previously submitted patch.