WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #57238, comment 10


Ignore:
Timestamp:
02/21/2023 01:09:28 PM (3 years ago)
Author:
abitofmind
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #57238, comment 10

    initial v1  
    1010
    11112) When the generated images are larger than the original, it indeed makes no sense to include them in the SRCSET.
    12 - a) In theory this should not happen if the sizing algorithm gets further optimized now (and continually gets improved whenever new edge cases get reported). Please investigate with the source material and findings I provided to you.
    13 - b) I agree that as a "last safety net" it is clever to exclude the smaller sized variants if larger in file size. I will create a separate ticket and cross-reference them.
    14 - c) You asked for which variants this happens: My assumptions from the observations:
     12- a) In theory this should not happen if the sizing algorithm gets further optimized now (and continually gets improved whenever new edge cases get reported).
     13  - Please investigate with the source material and findings I provided to you.
     14- b) I agree with the idea of a "last safety net" and filed a separate enhancement ticket:
     15  - #57781 Exclude sized variant from SRCSET if larger in file size than the original image
     16- c) "For which variants does this happens?" → My assumptions from the observations:
    1517  - c1) Each sized variant created by WP Core Media will always be smaller in file size then the next higher sized variant. I can truly not imagine any anomaly with these.
    1618  - c2) But the first X (ca. 1-2) sized variants may be larger in file size than the provided original if that original was very heavily optimized (as my provided samples prove, I'm a pro).