WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57298 closed defect (bug) (fixed)

Remove placeholder from `WP_Term_Query` cache key

Reported by: spacedmonkey Owned by: spacedmonkey
Priority: normal Milestone: 6.2
Component: Taxonomy Version: 4.6
Severity: normal Keywords: has-unit-tests has-patch needs-dev-note commit
Cc: Focuses: performance

Description

Follow up from [54634].

Cache key generation doesn't work when using escape placeholder in WP_Term_Query. The fix from [54634] should also be applied to WP_Term_Query.

Change History (12)

#1 @spacedmonkey
4 years ago

  • Summary Remove placeholder from WP_Term_Query → Remove placeholder from `WP_Term_Query` cache key

#2 @spacedmonkey
4 years ago

  • Focuses performance removed
  • Keywords needs-patch added

#3 @spacedmonkey
4 years ago

  • Focuses performance added

This ticket was mentioned in ​PR #3814 on ​WordPress/wordpress-develop by ​@spacedmonkey.
4 years ago #4

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/57298

#5 @spacedmonkey
4 years ago

Has patch now, worth reviewing.

​@spacedmonkey commented on ​PR #3814:
4 years ago #6

Unit tests added.

#7 @spacedmonkey
4 years ago

  • Keywords has-unit-tests needs-dev-note commit added

#8 @spacedmonkey
4 years ago

  • Owner set to spacedmonkey
  • Status new → assigned

#9 @spacedmonkey
4 years ago

  • Resolution → fixed
  • Status assigned → closed

In 55083:

Taxonomy: Remove placeholder from WP_Term_Query cache key.

Remove escape placeholder from query cache key, as placeholders are on a based on a unique id on every request. This meant that it is impossible for a cache to be reused, making queries that use escape placeholders such as searches, meta queries or using the description__like / name__like parameters were unable to be cached.

Follow on from [54634].

Props spacedmonkey, peterwilsoncc.
Fixes #57298.

#11 @milana_cap
4 years ago

@spacedmonkey, do we have a volunteer to write the Dev note?

#12 @flixos90
4 years ago

Drafted a note for this to be included in the Field Guide's notes section, as shared in ​https://wordpress.slack.com/archives/C02KGN5K076/p1677531978930639?thread_ts=1677512400.171959&cid=C02KGN5K076.

Note: See TracTickets for help on using tickets.