Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 11 months ago

#57324 closed task (blessed) (fixed)

Update jQuery v3.6.1 to v3.6.3

Reported by: tobiasbg's profile TobiasBg Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.2 Priority: normal
Severity: normal Version: 6.2
Component: External Libraries Keywords: add-to-field-guide has-patch needs-refresh commit
Focuses: Cc:

Description

Version 3.6.2 of jQuery has been released.

This release is a bug fix and improvement release. The jQuery team does not expect other compatibility issues when upgrading from a jQuery 3.0+ version.

A full list of changes in this release can be found on GitHub: https://github.com/jquery/jquery/compare/3.6.1...3.6.2.

For updating the jQuery version in WordPress, package.json and script-loader.php need to get the new version string.

Related: #56451, #52707, #51812, #50564, #37110.

Attachments (5)

57324.diff (1.2 KB) - added by naeemhaque 16 months ago.
Updated jQuery v3.6.2
57324.2.diff (698.3 KB) - added by naeemhaque 16 months ago.
Thanks @mukesh27.
57324.3.diff (698.3 KB) - added by naeemhaque 16 months ago.
Thanks @mukesh27. The updated package-lock.json file is added.
57324.4.diff (120.3 KB) - added by naeemhaque 16 months ago.
Updated JQuery v3.6.3
57324.5.diff (1.8 KB) - added by peterwilsoncc 16 months ago.

Download all attachments as: .zip

Change History (20)

@naeemhaque
16 months ago

Updated jQuery v3.6.2

#1 @naeemhaque
16 months ago

  • Keywords has-patch added; needs-patch removed
  • Summary changed from Update jQuery to version 3.6.2 to Update jQuery v3.6.1 to v3.6.2
  • Version set to trunk

I have already updated jQuery v3.6.1 to v3.6.2

#2 @mukesh27
16 months ago

  • Keywords needs-refresh added

Thanks @naeemhaque for the 57324.diff. The updated package-lock.json file is missing on the PR. Can you please add it?

@naeemhaque
16 months ago

Thanks @mukesh27.

@naeemhaque
16 months ago

Thanks @mukesh27. The updated package-lock.json file is added.

#3 follow-up: @mgol
16 months ago

Hey! jQuery Core Team member here. We’ve got a bug report with quite a serious issue in jQuery 3.6.2: https://github.com/jquery/jquery/issues/5177

The issue makes some native selectors not work in Firefox and it makes many selectors slower in that browser. We’re preparing jQuery 3.6.3 with just a fix for this issue and we plan to release it soon.

I’d advise to skip jQuery 3.6.2 and update straight to 3.6.3 when we ship it.

#4 in reply to: ↑ 3 @peterwilsoncc
16 months ago

  • Keywords changes-requested added

Replying to mgol:

Hey! jQuery Core Team member here. We’ve got a bug report with quite a serious issue in jQuery 3.6.2: https://github.com/jquery/jquery/issues/5177

...

I’d advise to skip jQuery 3.6.2 and update straight to 3.6.3 when we ship it.

Thanks for reaching out and letting folks know!

For want of a better keyword, I've added changes-requested pending the next minor release of jQuery. As WordPress 6.2 isn't due for some time, there's plenty of time for this to sit while the fix is worked on upstream.

#5 follow-up: @mgol
16 months ago

jQuery 3.6.3 has been released: https://blog.jquery.com/2022/12/20/jquery-3-6-3-released-a-quick-selector-fix/. You may update to that version now.

@naeemhaque
16 months ago

Updated JQuery v3.6.3

#6 in reply to: ↑ 5 @naeemhaque
16 months ago

  • Summary changed from Update jQuery v3.6.1 to v3.6.2 to Update jQuery v3.6.1 to v3.6.3

Replying to mgol:

jQuery 3.6.3 has been released: https://blog.jquery.com/2022/12/20/jquery-3-6-3-released-a-quick-selector-fix/. You may update to that version now.

Thanks, @mgol for the quick release.
@peterwilsoncc I've updated the jquery from v3.6.1 to v3.6.3.

#7 @peterwilsoncc
16 months ago

  • Keywords commit added; changes-requested removed

Thanks for the updated patch @naeemhaque.

I've tidied up the lock file a little in 57324.5.diff due to NPM oddities, possibly related to the version used.

Otherwise it's perfect, thanks!

#8 @peterwilsoncc
16 months ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 55012:

External Libraries: Update jQuery to 3.6.3.

Update the jQuery library from 3.6.1 to 3.6.3.

Props TobiasBg, naeemhaque, mukesh27, mgol.
Fixes #57324.

#9 @jorbin
13 months ago

In 55491:

External Libraries: Update jQuery to 3.6.4.

Update the jQuery library from 3.6.1 to 3.6.3.

[3.6.4 release announcement](https://blog.jquery.com/2023/03/08/jquery-3-6-4-released-selector-forgiveness/)
[Full changelog](https://github.com/jquery/jquery/compare/3.6.3...3.6.4)

Props TobiasBg, audrasjb, hellofromTonya.
See #57324.
Fixes 57888.

This ticket was mentioned in Slack in #core by mgol. View the logs.


13 months ago

#11 @nickpap
12 months ago

Not a major issue but jQuery version doesn't match
https://prnt.sc/9jAx9asonbwY

#12 @TobiasBg
12 months ago

@nickpap: Nice catch! It looks like line

$scripts->add( 'jquery-core', "/wp-includes/js/jquery/jquery$suffix.js", array(), '3.6.3' );

in /wp-includes/script-loader.php was not updated in [55491], accidentally.

Would you like to open a new ticket for this, so that this can be tracked against the current milestone?

#13 @nickpap
12 months ago

@TobiasBg Will do.

Thanks!

#14 @audrasjb
12 months ago

In 55713:

Script Loader: Update jQuery version to 3.6.4 to match the current version.

This changeset updates the jQuery version to 3.6.4 in script-loader.php to correcly match the current version used in WordPress.

This was accidentally missed in [55491].

Props nickpap, TobiasBg, dhrumilk.
Fixes #58203.
See #57324.

#15 @audrasjb
11 months ago

In 55730:

Script Loader: Update jQuery version to 3.6.4 to match the current version.

This changeset updates the jQuery version to 3.6.4 in script-loader.php to correctly match the current version used in WordPress.

This was accidentally missed in [55491].

Props nickpap, TobiasBg, dhrumilk.
Merges [55713] to the 6.2 branch.
Fixes #58203.
See #57324.

Note: See TracTickets for help on using tickets.