Opened 16 years ago
Closed 16 years ago
#5736 closed defect (bug) (fixed)
Merge profile.php and user-edit.php
Reported by: | nbachiyski | Owned by: | |
---|---|---|---|
Milestone: | 2.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | |
Focuses: | Cc: |
Description
Inspired by #5508, this patch tries to merge wp-admin/profile.php
and wp-admin/user-edit.php
, since these files contain much common code.
Some details:
- Both files are retained in order all old links to work.
profile.php
is almost empty and just sets a variable and loadsuser-edit.php
- Password strength meter and pluggable personal options are still available only on the profile page.
- The capability system was modified (with great help from Ryan) so that
current_user_can('edit_user', $uid)
returns true if the current user has id$uid
Attachments (1)
Change History (11)
#2
@
16 years ago
This one function is presentation-oriented and isn't used anywhere else, so it would better stay there.
#6
@
16 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
profile-update.php
is no longer needed -- all the work is done in user-edit.php
Note: See
TracTickets for help on using
tickets.
That is a pretty sweet patch. I'll see about testing it over the weekend. If at all possible, can you move the function outside of the file into another file in the wp-admin/includes folder?
I think the goal is to have as much separate of presentation and business logic as possible. Just a suggestion, if you want to spend time doing it.