Twenty Twenty: Remove Unused function parameter and variable.

[upadalavipul]

I have reviewed twenty-twenty theme codes and I found some of the function parameters and variables Unused. So I have to remove it from the below files.

Files:

• twentytwenty/classes/class-twentytwenty-walker-page.php
• twentytwenty/inc/template-tags.php

[sabernhardt]

Not using the $n line break variable may have been a mistake, though removing the variable probably would be better than adding it to the markup now.

The global $post variable should stay. According to the ​setup_postdata documentation, "setup_postdata() does not assign the global $post variable so it’s important that you do this yourself."

When removing the last parameter from the twentytwenty_filter_wp_list_pages_item_classes and twentytwenty_add_sub_toggles_to_main_menu functions, also remove the parameter from those functions' documentation and decrease the count argument in the related filters. (See #57397)

[sabernhardt]

#58601 was marked as a duplicate.

• Removes $n variable from TwentyTwenty_Walker_Page class start_el()
• Removes last parameter from twentytwenty_filter_wp_list_pages_item_classes() and twentytwenty_add_sub_toggles_to_main_menu()

Trac ticket: https://core.trac.wordpress.org/ticket/57371

[mukesh27]

Replying to sabernhardt:

The global $post variable should stay. According to the ​setup_postdata documentation, "setup_postdata() does not assign the global $post variable so it’s important that you do this yourself."

I argue that if we already pass the post ID to the setup_postdata function, then why do we need to use the global variable?

[sabernhardt]

I removed the global, and the post's tag still appeared in the meta section as expected. If that variable is necessary or if we are unsure, I can revert that last change.

[audrasjb]

In 56045:

Twenty Twenty: Remove various unused function parameters and variables.

This removes the $n variable from TwentyTwenty_Walker_Page class start_el() function, removes an unused global and the last parameter from
twentytwenty_filter_wp_list_pages_item_classes() and twentytwenty_add_sub_toggles_to_main_menu().

Props upadalavipul, sabernhardt, mukesh27.
Fixes #57371.

committed in https://core.trac.wordpress.org/changeset/56045