Make WordPress Core

#57387 closed enhancement (fixed)

use aligncenter class in about page sub-heading

Reported by: shagors's profile shagors Owned by: audrasjb's profile audrasjb
Milestone: 6.2.1 Priority: normal
Severity: normal Version: 6.1.1
Component: Help/About Keywords: has-patch commit fixed-major
Focuses: Cc:

Description (last modified by sabernhardt)

on about.php heading was center aligned and the sub-heading is left aligned
it's looking odd
if we do both centers align it will look better
just add the "aligncenter" class in the sub-heading tag in about.php

Attachments (5)

About-WP6.1.1.png (121.1 KB) - added by sabernhardt 16 months ago.
About page with first two subheadings
About-WP6.0.3.png (45.6 KB) - added by sabernhardt 13 months ago.
About page for 6.0 had centered heading with a left-aligned paragraph, too
About-WP6.2-trunk.png (23.5 KB) - added by sabernhardt 13 months ago.
current page in 6.2 centers both the heading and the following paragraph
After-PR-3807.jpg (105.1 KB) - added by costdev 12 months ago.
After PR 3807
screencapture-localhost-8888-552-wordpress-18-wp-admin-about-php-2023-05-03-23_49_01.png (656.8 KB) - added by audrasjb 12 months ago.
Looking good on 6.3 alpha

Download all attachments as: .zip

Change History (27)

@sabernhardt
16 months ago

About page with first two subheadings

#1 follow-up: @sabernhardt
16 months ago

  • Component changed from General to Help/About
  • Description modified (diff)
  • Milestone changed from Awaiting Review to 6.1.2
  • Version changed from trunk to 6.1.1

Hi and thanks for the ticket!

I prefer aligning the "Welcome to WordPress 6.1.x" subheading to the left instead. Future minor releases will add more left-aligned paragraphs under Maintenance and Security Releases.

Either way, using the same alignment for both subheadings should be good.

This ticket was mentioned in PR #3807 on WordPress/wordpress-develop by @mukesh27.


16 months ago
#2

  • Keywords has-patch added

#3 @mukesh27
16 months ago

Hi there! thanks for the ticket.

PR 3807 set left alignment for the title.

#4 in reply to: ↑ 1 @shagors
16 months ago

Replying to sabernhardt:

Hi and thanks for the ticket!

I prefer aligning the "Welcome to WordPress 6.1.x" subheading to the left instead. Future minor releases will add more left-aligned paragraphs under Maintenance and Security Releases.

Either way, using the same alignment for both subheadings should be good.

Hi @sabernhardt,

Yes, it's good for both headings' same alignment.
@mukesh27 thanks for the PR.

Regards,
Shagor

#5 @amin7
14 months ago

Test Report

This report validates that the indicated patch added the enhancement.
Patch tested:
https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/3807.diff

Environment

OS: Windows 10 version 22H2
Web Server: Nginx
PHP: 7.4.30
WordPress: 6.1.1
Browser: Chrome 109.0.5414.87
Theme: Twenty Twenty-Three
Active Plugins: No plugins activated.

Before Patch
Subtitle center aligned, Screenshot https://d.pr/i/jQXPwL

After Patch
Subtitle left aligned, Screenshot https://d.pr/G0L5qI


✅ Patch is working as per the enhancement request.

This ticket was mentioned in Slack in #core by sergey. View the logs.


13 months ago

#7 @costdev
13 months ago

  • Keywords needs-testing added
  • Milestone changed from 6.1.2 to 6.2

This ticket was discussed during the bug scrub.

Here is the summary:

  • Sergey: I think it might apply to the 6.2 About page too.
  • Tonya: Maybe test it against 6.2 about page and then fix the alignment if off by RC2? ie for the 6.2 About page only (not 6.1's)
  • Sergey: Should be moved to 6.2 then 👍
  • Tonya: I don't think 6.1 About page though will be fixed as I don't think we'll go back to it or have another point release.

Additional props: @SergeyBiryukov @hellofromTonya

@sabernhardt
13 months ago

About page for 6.0 had centered heading with a left-aligned paragraph, too

@sabernhardt
13 months ago

current page in 6.2 centers both the heading and the following paragraph

#8 @costdev
13 months ago

  • Milestone changed from 6.2 to 6.2.1

After further discussion, moving this ticket to 6.2.1

#9 @sabernhardt
13 months ago

It might not be worth backporting to 6.1 because 6.0 had the same alignments.

I do not like centering an entire paragraph, but that could make the alignment seem a little more consistent in 6.2.1.

@costdev
12 months ago

After PR 3807

#10 @costdev
12 months ago

  • Keywords needs-testing removed

I agree that it's not really worth backporting to the 6.1 branch.

PR 3807, which left aligns the heading and paragraph, looks good to me.

All of the headings and paragraphs in the "What's New" tab are left aligned, so this makes the first heading/paragraph consistent with all others.

As there is already a test report for PR 3807 that accurately reflects the results of the PR, removing needs-testing.

@sabernhardt What do you think of PR 3807's results?

#11 @sabernhardt
12 months ago

PR 3807 should work for 6.1.2, matching the alignment of the maintenance releases section.

If aligning left for 6.2.1, the aligncenter class would need to be removed from the is-subheading paragraph, too.

This ticket was mentioned in PR #4306 on WordPress/wordpress-develop by @costdev.


12 months ago
#12

This removes the aligncenter class from the h2 and is-subheading in the WordPress 6.2 About Page for consistent alignment.

Trac ticket: https://core.trac.wordpress.org/ticket/57387

#13 @costdev
12 months ago

Right you are @sabernhardt! I hadn't spotted that change to is-subheading!

PR 4306 aims to handle this for 6.2.1.

#14 @costdev
12 months ago

  • Keywords needs-testing added

Adding needs-testing to confirm PR 4306 works as we expect.

This ticket was mentioned in Slack in #core-test by costdev. View the logs.


12 months ago

#16 @pavanpatil1
12 months ago

Hi,

Verified the / patch. It is working as expected.

Environment:
WordPress - 6.2
OS- Windows10

Before Patch:
https://prnt.sc/o0tGjTGnJVO9

After Patch:
https://prnt.sc/--BLIFAS2rbN

#17 @audrasjb
12 months ago

  • Keywords commit added; needs-testing removed
  • Owner set to audrasjb
  • Status changed from new to accepted

Marking for commit consideration, so we can start working on 6.2.1 about page update :)

@audrasjb commented on PR #3807:


12 months ago
#18

Closing this PR in favor ok #4306

#19 @audrasjb
12 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55716:

Help/About: Left-align 6.2 about page subheading.

This changeset removes the aligncenter class from h2 and is-subheading items in the WordPress 6.2 About Page, for more consistent alignment. Also, future minor releases will add more left-aligned paragraphs under the "Maintenance Releases" section.

Props shagors, sabernhardt, mukesh27, amin7, costdev, pavanpatil1, audrasjb.
Fixes #57387.

#21 @audrasjb
12 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 6.2 backport.

#22 @audrasjb
11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 55731:

Help/About: Left-align 6.2 about page subheading.

This changeset removes the aligncenter class from h2 and is-subheading items in the WordPress 6.2 About Page, for more consistent alignment. Also, future minor releases will add more left-aligned paragraphs under the "Maintenance Releases" section.

Props shagors, sabernhardt, mukesh27, amin7, costdev, pavanpatil1, audrasjb.
Merges [55716] to the 6.2 branch.
Fixes #57387.

Note: See TracTickets for help on using tickets.