Twenty Nineteen: Remove Unused function parameter and variable.

[upadalavipul]

I have reviewed twenty-nineteen theme codes and I found some of the function parameters and variables Unused. So I have to remove it from the below files.

Files:

• twentynineteen/comments.php
• twentynineteen/inc/template-functions.php

[hellofromTonya]

Hello @upadalavipul,

Welcome to back to WordPress Core's Trac!

I'm doing prep before tomorrow's 6.2 RC1 and noticed this ticket's Version is set to trunk (saw it in Report 40). The code for this ticket was not introduced in 6.2. So I'll remove trunk as the Version.

Trac ticket: https://core.trac.wordpress.org/ticket/57397

[mukesh27]

Hi there!

Thanks for the ticket.

In ​PR #4225 I have used different approaches to solve the issue.

[costdev]

​PR 4225 looks good to me and adjusts the add_filter() calls to reduce the number of accepted arguments.

Adding for commit consideration.

[sabernhardt]

Version set to 5.0

History from GitHub repository:

• ​Comments navigation in initial commit
• ​Adding 'entry' to post classes
• ​Adding nav menu link attributes

[sabernhardt]

1. The twentynineteen_post_thumbnail_sizes_attr filter shows the default priority and accepted arguments , 10, 1. The two filters could be consistent.
2. The twentynineteen_nav_menu_link_attributes DocBlock has a typo we could fix (either here or on #57840): "Adjustments to menu attributes tot support WCAG 2.0 recommendations for flyout and dropdown menus."
3. I like that the PR uses the variable for comments navigation, but those translations probably should be replaced anyway (on a new ticket, #58149). Separating "Previous" and "Next" from "Comments" can result in faulty translations.

Changeset 55655 replaced the comments navigation text strings for better translations, so the $comments_text variable is already removed from comments.php.

[mukesh27]

​PR 4225 get several approvals. @SergeyBiryukov Could you please review it.

Adding for commit consideration.

[audrasjb]

Self assigning for final review 👀

[audrasjb]

This looks good. I also spotted a few other docblock issues or improvements in this file and will commit them directly.

[audrasjb]

In 55963:

Twenty Nineteen: Remove unused function parameters and variables.

This changeset removes unused parameters and variables, fixes a typo, and improves some docblocks as per documentation standards.

Props upadalavipul, mukesh27, costdev, sabernhardt, hellofromtonya, audrasjb.
Fixes #57397.

committed in https://core.trac.wordpress.org/changeset/55963

[viralsampat]

I have worked on another theme and found same issue, Here I have added my patch for another theme.

[SergeyBiryukov]

@viralsampat Thanks for the patch! It appears that these changes are already done as part of [55655] and [56045].

Please also note the message above the comment form:

This ticket was closed on a completed milestone.
If you have a bug or enhancement to report, please open a new ticket.