Make WordPress Core

Opened 14 months ago

Closed 8 months ago

#57414 closed defect (bug) (fixed)

Twenty Ten: The color of the plus icon should be white in Add Block button

Reported by: umesh84's profile umesh84 Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.1.1
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: ui, css Cc:

Description

In Twenty Ten Theme, The color of the plus icon should be white in Add Block button

Attachments (5)

CleanShot 2023-01-03 at 16.07.16@2x.png (546.6 KB) - added by umesh84 14 months ago.
For better understanding I have attached a screenshot
#57414.patch (477 bytes) - added by kajalgohel 14 months ago.
patch added
57414.2.patch (484 bytes) - added by sabernhardt 11 months ago.
removes extra spaces and uses 3-character color code
7a087379e6469e3c4f58574e0c0c7968.gif (20.1 KB) - added by audrasjb 8 months ago.
Before patch :'(
f6c73d262fd3a9e58112b0723323efdd.gif (19.5 KB) - added by audrasjb 8 months ago.
After patch \o/

Download all attachments as: .zip

Change History (12)

@umesh84
14 months ago

For better understanding I have attached a screenshot

@kajalgohel
14 months ago

patch added

#1 @naeemhaque
14 months ago

  • Keywords has-patch has-screenshots added; needs-patch removed

@sabernhardt
11 months ago

removes extra spaces and uses 3-character color code

#2 @sabernhardt
11 months ago

  • Milestone changed from Awaiting Review to 6.3

To meet coding standards, I updated the patch for Twenty Ten.

However, it may be better to add the color to all child elements of the toggle button within the editor for any theme (probably after the :hover state).

		& * {
			color: $white;
		}
Last edited 11 months ago by sabernhardt (previous) (diff)

#3 @pooja1210
11 months ago

Hi,

Tested the patch and it's working fine. With Twenty Ten Theme, the color of the Add Block button(plus icon) is appearing white after the fix.

Test Environment:
WordPress: 6.2
Theme: Twenty Ten
OS: MacOS
Browser: Chrome

Issue Before Patch: https://prnt.sc/lukTTPINSX9O

Fix After Patch Added: https://prnt.sc/bJTolmDvwz8W

Thanks!

#4 @amin7
10 months ago

Test Report


Patch tested: https://core.trac.wordpress.org/attachment/ticket/57414/%2357414.patch

Environment

OS: Windows 10 version 22H2
Web Server: Nginx
PHP: 8.1.9
WordPress: 6.2
Browser: Chrome 109.0.5414.87
Theme: Twenty Ten
Active Plugins: No plugins activated.

Actual Results


✅ The color of the plus icon from add block button is now white

Supplemental Artifacts

Before Patch: https://d.pr/i/KtPEbA
After Patch: https://d.pr/i/mcDz5x

#5 @sabernhardt
9 months ago

GB46568 may correct this for multiple themes, but I'll leave this open for now.

#6 @audrasjb
8 months ago

Given the related PR on Gutenberg was closed, I'd say it's probably better (and doesn't hurt) to fix it on Twenty Ten anyway…
See https://github.com/WordPress/gutenberg/pull/46636

@audrasjb
8 months ago

Before patch :'(

@audrasjb
8 months ago

After patch \o/

#7 @audrasjb
8 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 56081:

Twenty Ten: Prevent Block Inserter icon color override.

This changeset prevents the likes of body * { color: #000; } in custom styles to override the Block Inserter icon styles.

Props umesh84, kajalgohel, sabernhardt, pooja1210, amin7.
Fixes #57414.

Note: See TracTickets for help on using tickets.