Typo in wp-includes/class-pop3.php

[nitman43]

If we look at wp-includes/class-pop3.php on line 446 we can see it is includ. I think the right one should be include.

Do NOT includ the \r\n as part of your command

[manojkpatil]

Added patch

[kebbet]

I thought this file was included in WordPress and that the typo should be reported upstream.

But: when looking at the file history WordPress commiters has been touching the file for two decades without any reference to a upstream source. The file is excluded from the wpcs config.
​https://github.com/WordPress/wordpress-develop/commits/b43712e0f79a9f5bea52217e06155e2f471c490c/wp-includes/class-pop3.php?browsing_rename_history=true&new_path=src/wp-includes/class-pop3.php&original_branch=6.1

So: not really sure what upstream is and how to handle the typo here. More experienced contributers might have a better idea.

[nitman43]

@audrasjb what is the right way forward for this ticket?

[audrasjb]

Thanks for the heads up!

Indeed, this file was adopted by WordPress Core, so it can be edited directly in Core, and doesn't need to be updated upstream and backported, @kebbet.

Self assigning for commit.

[audrasjb]

In 55073:

Docs: Typo correction in POP3 class send_cmd() inline docs.

Props nitman43, manojkpatil, kebbet.
Fixes #57449.
See #56792.