Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#57449 closed defect (bug) (fixed)

Typo in wp-includes/class-pop3.php

Reported by: nitman43's profile nitman43 Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

If we look at wp-includes/class-pop3.php on line 446 we can see it is includ. I think the right one should be include.

Do NOT includ the \r\n as part of your command

Attachments (1)

57449.patch (1.3 KB) - added by manojkpatil 8 months ago.
Added patch

Download all attachments as: .zip

Change History (6)

@manojkpatil
8 months ago

Added patch

#1 @manojkpatil
8 months ago

  • Component changed from Database to General
  • Keywords has-patch added

#2 @kebbet
8 months ago

I thought this file was included in WordPress and that the typo should be reported upstream.

But: when looking at the file history WordPress commiters has been touching the file for two decades without any reference to a upstream source. The file is excluded from the wpcs config.
https://github.com/WordPress/wordpress-develop/commits/b43712e0f79a9f5bea52217e06155e2f471c490c/wp-includes/class-pop3.php?browsing_rename_history=true&new_path=src/wp-includes/class-pop3.php&original_branch=6.1

So: not really sure what upstream is and how to handle the typo here. More experienced contributers might have a better idea.

#3 @nitman43
8 months ago

@audrasjb what is the right way forward for this ticket?

#4 @audrasjb
8 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.2
  • Owner set to audrasjb
  • Status changed from new to accepted
  • Version 6.1.1 deleted

Thanks for the heads up!

Indeed, this file was adopted by WordPress Core, so it can be edited directly in Core, and doesn't need to be updated upstream and backported, @kebbet.

Self assigning for commit.

#5 @audrasjb
8 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55073:

Docs: Typo correction in POP3 class send_cmd() inline docs.

Props nitman43, manojkpatil, kebbet.
Fixes #57449.
See #56792.

Note: See TracTickets for help on using tickets.