Add id of the post to the 'the_title' filter

[henrikmelin]

When the id of a post is specified in get_the_title($id), it is not always possible to get the ID of the post in the 'the_title' filter, since the post is not necessarily held in $post. For a good example of this see the' Activity Box' on the Dashboard.

One reason one would want the id is to modify the title with, e.g. values held in custom fields.

I propose that the id is passed as an argument to the 'the_title' filter as follows:

function get_the_title($id = 0) {

...
return apply_filters( 'the_title', $title, $post->ID );

}

Which would always make the (correct) id available to the filter.

Cheers,
Henrik.

[DD32]

Make it so.

[DD32]

I can see that for some people, It'd be good to know which post title the filter is modifing, so i've made a patch.

[Denis-de-Bernardy]

Imho, the same could be said for the_content, the_excerpt, and other post-related filters.

Then again, get_the_ID() can return the ID while in the loop, and this is good enough as far as I can tell.

[DD32]

Hm.. I've actually got a use for this now.. - I've got a the_title filter which is used to add a prefix to blog posts based on the categories of the post.

The issue is that when displaying the title outside of the loop, The filter function doesnt have a clue what post its supposed to be applying the filter to.

Places where its used outside of the loop include custom loops on the homepage, or in sublists within the blog page (Which is a place AFAIK, you do not want to have an extra loop to prevent mucking up its parent?)

[westi]

I still need to do my filter review to stop the same filter name being used in multiple places.

Passing extra stuff with filters can't be a bad idea though.

[DD32]

I still need to do my filter review to stop the same filter name being used in multiple places.

Yep.. For example this use of the_title: ​http://trac.wordpress.org/browser/trunk/wp-includes/link-template.php#L607

Might be nice to standardise on that format then.

[Denis-de-Bernardy]

See dup: #9319 (suggests passing $post instead)

[Denis-de-Bernardy]

Closing as dup of #9666

[ryan]

(In [11112]) Pass post ID to the_title filter. Props DD32. see #5746 #9666