WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#57467 closed defect (bug) (fixed)

Typo in wp-includes/rss.php

Reported by: lanacodes's profile lanacodes Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: low
Severity: trivial Version:
Component: Feeds Keywords: has-patch
Focuses: docs Cc:

Description

wp-includes/rss.php line 839:

# regex to match wc3dtf

Incorrectly has "WC3" instead of "W3C".

Attachments (2)

57467.diff​ (1008 bytes) - added by lanacodes 2 years ago.
Change "wc3dtf" to "w3cdtf".
57467.date-time-formats.diff​ (510 bytes) - added by sabernhardt 2 years ago.
spells out "W3C date/time formats"

Download all attachments as: .zip

Change History (10)

@lanacodes
2 years ago

Change "wc3dtf" to "w3cdtf".

#1 @krupalpanchal
2 years ago

  • Keywords has-patch added
  • Severity changed from trivial to normal

#2 @sabernhardt
2 years ago

  • Component changed from General to Feeds
  • Focuses docs added

Thanks for the report and the patch!

This file has been deprecated for years, so it might not be worth fixing typos (see #57102 and #57107).

If we change this, however, I'd suggest replacing DTF with what it represents, too.
regex to match W3C date/time format

Last edited 2 years ago by sabernhardt (previous) (diff)

#3 @sabernhardt
2 years ago

  • Milestone changed from Awaiting Review to 6.3

The typos in #57102 were fixed, so this could be worth fixing, too.

Last edited 2 years ago by sabernhardt (previous) (diff)

#4 @audrasjb
2 years ago

  • Priority changed from normal to low
  • Severity changed from normal to trivial
  • Version 6.1.1 deleted

Self assigning for review

#5 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#6 @nithins53
2 years ago

Even though it's deprecated, since it's part of the core, fixing it would be a good idea.

@sabernhardt
2 years ago

spells out "W3C date/time formats"

#7 @sabernhardt
2 years ago

The ​W3C page has "date/time formats" a few times, so I used that.

#8 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55644:

Docs: Fix a typo in wp-includes/rss.php inline comments.

This changeset replaces "wc3dtf" with "W3C date/time formats" to fix a typo and to provide a better description of the related code.

Props lanacodes, sabernhardt, nithins53.
Fixes #57467.

Note: See TracTickets for help on using tickets.