Changes between Initial Version and Version 5 of Ticket #57469

Timestamp:

08/08/2023 02:32:08 PM (3 years ago)

Author:

hellofromTonya

Comment:

Changes in the ticket:

• Updated the Summary to better reflect the issue being reported, i.e. for discoverability.
• Updated the Version to 4.9.
• Wrapped the PHP error in the Description.
• Reset the keywords as the PR was closed.
• Changed keyword to php80 to identify which PHP version increased the error's severity.

Error across PHP versions: If null or a non-array is set for the widgets of a sidebar, then PHP throws an error (see it in action ​https://3v4l.org/i45nZ):

• < 7.3: Warning: array_merge(): Argument #3 is not an array
• PHP 7.3 to 7.4: Warning: array_merge(): Expected parameter 3 to be an array, null given
• PHP 8+: Fatal error: Uncaught TypeError: array_merge(): Argument #3 must be of type array, null given.

Historical context:

• [41555] / #39693 (during WP 4.9):
  • Introduced wp_map_sidebars_widgets().
  • retrieve_widgets():
    • Invoked wp_map_sidebars_widgets() to map $sidebars_widgets
    • Added $shown_widgets = call_user_func_array( 'array_merge', $sidebars_widgets );.
• [48839] / #50913 (during WP 5.6):
  • retrieve_widgets(): changed call_user_func_array( 'array_merge', $sidebars_widgets ); to array_merge( ...array_values( $sidebars_widgets ) );.