Make WordPress Core

Opened 14 months ago

Last modified 13 months ago

#57472 new defect (bug)

Twenty Twelve theme: Pullquote block alignment issue in backend site

Reported by: umesh84's profile umesh84 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.1.1
Component: Bundled Theme Keywords: has-screenshots has-patch
Focuses: ui, css Cc:

Description

In Twenty Twelve Theme: when we add a Pullquote Block on the
Editor-side alignment is not proper.

Attachments (2)

CleanShot 2023-01-16 at 18.48.34@2x.png (244.1 KB) - added by umesh84 14 months ago.
For better understanding I have attached a screenshot
default.jpg (110.4 KB) - added by nithins53 14 months ago.
Even if alignment is set to None, the pullquote is a bit towards the left and not in the center. I think that is what is being referred to here.

Download all attachments as: .zip

Change History (7)

@umesh84
14 months ago

For better understanding I have attached a screenshot

#1 @poena
14 months ago

Hi, are you able to provide any more details?

I am not able to see from the screenshot which alignment that is selected in the block options, if it is set to left, wide, or perhaps none: and I do not know what result you expected.

Does it display correctly on the front?

@nithins53
14 months ago

Even if alignment is set to None, the pullquote is a bit towards the left and not in the center. I think that is what is being referred to here.

#2 @nithins53
14 months ago

In other themes, if we insert a pullquote block in the editor side, the pullquote is placed in the middle but in Twenty twelve it moves to the left a bit. @umesh84 is this what you are referring to?

#3 @adeltahri
13 months ago

I reproduced this issue with WordPress version 6.2.0 too, the issue
on editor-blocks.css

this CSS code on editor-blocks.css should be removed.

.edit-post-visual-editor .wp-block-pullquote {
    margin: 0;
}

WordPress Core already has this one:

.editor-styles-wrapper .wp-block {
    margin-left: auto;
    margin-right: auto;
}

This ticket was mentioned in PR #3884 on WordPress/wordpress-develop by AdelDima.


13 months ago
#4

  • Keywords has-patch added; needs-patch removed

#5 @bgoewert
13 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/3884

Environment

  • OS: Pop!_OS 22.04
  • Web Server: Docker Desktop & wordpress-develop
  • PHP: 7.4.33
  • WordPress: 6.2-alpha-54642-src
  • Browser: Chrome 109, Firefox 108
  • Theme: Twenty Twelve
  • Active Plugins: none

Actual Results

  • ✅ Issue resolved with patch.

Supplemental Artifacts

Before applying patch
https://i.imgur.com/JMPNO9P.png

After applying patch
https://i.imgur.com/wUYWjm8.png

Note: See TracTickets for help on using tickets.