WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#57480 closed enhancement (fixed)

Editor: Remove unused '__unstableHomeTemplate' "home template" setting.

Reported by: youknowriad's profile youknowriad Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch gutenberg-merge commit
Focuses: Cc:

Description (last modified by hellofromTonya)

The site editor has been updated to not require the "home template" setting. The Editor's initialization needs updating to remove this unused key / setting.

Reference:

Change History (12)

This ticket was mentioned in ​PR #3855 on ​WordPress/wordpress-develop by ​@youknowriad.
2 years ago #1

  • Keywords has-patch added

Trac ticket https://core.trac.wordpress.org/ticket/57480

Related Gutenberg PRs:

​https://github.com/WordPress/gutenberg/pull/44770

This updates the site initialization to match Gutenberg by removing a key that is not used anymore. That said, we can't land this PR until the package updates happens.

@Mamaduka @ntsekouras

#2 @youknowriad
2 years ago

  • Keywords Gutenberg-merge added

#3 @hellofromTonya
2 years ago

  • Keywords gutenberg-merge commit added; Gutenberg-merge removed
  • Owner set to hellofromTonya
  • Status changed from assigned to reviewing

Marking for commit. Self-assigning.

#4 @hellofromTonya
2 years ago

Aha just saw the note from @youknowriad

This updates the site initialization to match Gutenberg by removing a key that is not used anymore. That said, we can't land this PR until the package updates happens.

The commit for this needs to wait until the package updates are committed. @youknowriad feel free to self-assign ownership when the time comes to commit. Else, I'll take care of it.

This ticket was mentioned in ​Slack in #core-editor by hellofromtonya. ​View the logs.
2 years ago

#6 @hellofromTonya
2 years ago

  • Description modified (diff)
  • Summary changed from Backport the changes to site-editor.php from the Gutenberg plugin. to Editor: Remove unused '__unstableHomeTemplate' "home template" setting.

#7 @hellofromTonya
2 years ago

  • Owner hellofromTonya deleted

Unassigning myself.

​@hellofromTonya commented on ​PR #3855:
2 years ago #8

What are risks to users and extenders by hard removing this setting?
Thinking of backwards-compatibility (BC)

Searched the wporg repos for usage:

​@ntsekouras commented on ​PR #3855:
2 years ago #9

What are risks to users and extenders by hard removing this setting?

Thinking of backwards-compatibility (BC)

It seems there is no BC issue. It was discussed in the ​original GB PR.

#10 @audrasjb
2 years ago

  • Owner set to audrasjb

Re-assigning to myself in replacement of Tonya for the final review/merge. As said above, this changeset needs to wait for package update to be shipped.

Last edited 2 years ago by audrasjb (previous) (diff)

#11 @youknowriad
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55247:

Site Editor: Backport site editor intialization changes from Gutenberg 15.1

The site editor has been updated to not require the "home template" setting.
This removes the key from the settings passed to the frontend.

Props flixos90, hellofromtonya, ntsekouras.
Fixes #57480.

Note: See TracTickets for help on using tickets.