Remove the Unused variables in the wp-includes folder.

[upadalavipul]

I have reviewed the code and found Unused variables in some of the below files. Please below files:

Files:

---

1. /wp-includes/SimplePie/Item.php
2. /wp-includes/SimplePie/Locator.php
3. /wp-includes/class-wp-comment-query.php
4. /wp-includes/feed-atom.php

[dingo_d]

Isn't SimplePie a bundled lib for RSS? Not sure, but maybe this should be fixed upstream?

Also, in the Locator.php, you have just commented the lines out, if things are not used, then it's better that they are removed (they are all versioned files, so the change can always be reverted).

For the $more variable, I'm not sure it's unused (all the other feed files have it so it could be used in some way). Also Phpstorm didn't report it as unused for me.

[audrasjb]

Hello and thanks for the ticket/patch,

Yes, SimplePie is an external dependency that need to be fixed upstream: ​https://github.com/simplepie/simplepie

[SergeyBiryukov]

In 55559:

Coding Standards: Remove unused variables in WP_Comment_Query.

• $unapproved_ids and $unapproved_emails in WP_Comment_Query::get_comment_ids() were added in [29965] and appear to never have been used.
• $wpdb in WP_Comment_Query::fill_descendants() was replaced with $this->db in [38275], removed in [38446], and accidentally reinstated in [38768].

Follow-up to [29965], [34546], [37625], [38275], [38446], [38768], [44546].

Props upadalavipul, dingo_d, audrasjb, SergeyBiryukov.
Fixes #57482.

[SergeyBiryukov]

Re: 57482.2.patch​, as noted above, SimplePie is an external library and should not be patched here, any suggested changes to its files should be submitted upstream: ​https://github.com/simplepie/simplepie.