Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#57493 closed enhancement (fixed)

Add "Robohash" support for avatar_default

Reported by: juliobox's profile juliobox Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: trivial Version:
Component: Users Keywords: has-patch has-screenshots needs-user-docs
Focuses: Cc:

Description

Hello

Since Gravatar is officially handling RoboHash as avatars, we should add it to WordPress.

Source: https://en.gravatar.com/site/implement/images/
Test: add_filter( 'pre_option_avatar_default', function() { return 'robohash'; } );
File: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/options-discussion.php#L276
Patch: 'robohash' => __( 'RoboHash (Generated)' ),
Github PR:
Thanks for reading.

Attachments (2)

Capture d’écran 2023-01-18 à 10.57.43.png (172.8 KB) - added by audrasjb 15 months ago.
Works fine on the admin screen
Capture d’écran 2023-01-18 à 11.03.00.png (90.5 KB) - added by audrasjb 15 months ago.
Works fine on front-end when robohash is selected as default avatar option

Download all attachments as: .zip

Change History (14)

This ticket was mentioned in PR #3859 on WordPress/wordpress-develop by @juliobox.


15 months ago
#1

  • Keywords has-patch added

Add support for "RoboHash" avatars for Gravatar
This is a native option, source: https://en.gravatar.com/site/implement/images/

Trac ticket: https://core.trac.wordpress.org/ticket/57493#ticket

#2 in reply to: ↑ description @juliobox
15 months ago

Last edited 15 months ago by juliobox (previous) (diff)

#3 @audrasjb
15 months ago

Thanks for the ticket and patch!

I added a commit to your PR to remove an unwanted whitespace for better WPCS compliance :)

@audrasjb
15 months ago

Works fine on the admin screen

@audrasjb
15 months ago

Works fine on front-end when robohash is selected as default avatar option

#4 @audrasjb
15 months ago

  • Keywords has-screenshots added
  • Milestone changed from Awaiting Review to 6.2

Moving for 6.2 consideration.

#5 @audrasjb
15 months ago

  • Keywords commit added

Self assigning for commit.

#6 @audrasjb
15 months ago

  • Keywords needs-user-docs added

#7 @audrasjb
15 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


15 months ago

#9 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55238:

Users: Add support for RoboHash Gravatar images in default user profile pics.

Gravatar includes support for RoboHash auto-generated images. This changeset adds it to the built-in feature for user profile images.

See Gravatar docs: https://en.gravatar.com/site/implement/images/.

Props juliobox, audrasjb.
Fixes #57493.

#10 @audrasjb
15 months ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to address a follow-up commit: I noticed we also need to update two function docblocks. Follow-up commit incoming.

#11 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 55239:

Users: Update get_avatar_url() and get_avatar() to include RoboHash support.

Follow-up to [55238].

Fixes #57493.

Note: See TracTickets for help on using tickets.