WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #57506, comment 7


Ignore:
Timestamp:
06/15/2023 07:51:37 PM (3 years ago)
Author:
sabernhardt

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #57506, comment 7

    initial v1  
    3357506.1.diff and 57506.2.patch add the left border—even in RTL—to both Default and Plain styles. (Twenty Twenty-Two does not have the border in Plain style, and its Default style has the border on the right for right-to-left languages.)
    44
    5 Between the two patches, I prefer 57506.2.patch. It lists styles in the same color-style-width order that is used in the Aubergine and Canary JSON files. The [https://github.com/WordPress/gutenberg/blob/dd9bc7b206adf2c8a17a017945e80f3e97f73407/packages/block-library/src/quote/theme.scss#L2 themes.scss] file has `currentColor`, which might be a better choice than `inherit` (or `initial`).
     5Between the two patches, I prefer 57506.2.patch. It lists styles in the same color-style-width order that is used in the Aubergine and Canary JSON files. The [https://github.com/WordPress/gutenberg/blob/dd9bc7b206adf2c8a17a017945e80f3e97f73407/packages/block-library/src/quote/theme.scss#L2 theme.scss] file has `currentColor`, which might be a better choice than `inherit` (or `initial`).