Changes between Initial Version and Version 1 of Ticket #57516, comment 7
- Timestamp:
- 01/20/2023 06:36:10 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #57516, comment 7
initial v1 1 1 I've submitted [https://github.com/WordPress/wordpress-develop/pull/3877 PR 3877]. 2 2 3 There's an additional benefit for the filesystem classes that by using `$path = trailingslashit( $path )` before it's concatenated, the code is easier to read, and unnecessary concatenation isn't done in every iteration of the FTP loops.3 There's an additional benefit for the filesystem classes that by using `$path = trailingslashit( $path )` before the `while()/foreach()` loops, the code is easier to read, and unnecessary concatenation isn't done in every iteration of the FTP loops. 4 4 5 5 All uses of `$path` after the PR's `$path = trailingslashit( $path )` were previously concatenated, so this doesn't cause any issues later.