WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57526 closed enhancement (fixed)

Globals Styles Endpoint: Declare 'edit_css' capability in links

Reported by: Mamaduka Owned by: hellofromTonya
Priority: normal Milestone: 6.2
Component: REST API Version: 5.9
Severity: normal Keywords: has-patch has-unit-tests gutenberg-merge commit
Cc: Focuses:

Description (last modified by hellofromTonya)

Update the Global Styles endpoint to expose the 'edit_css' capability via action links.

This is the part of an effort to hide custom CSS setting for users without 'edit_css' capability. See ​https://github.com/WordPress/gutenberg/pull/46815.

Change History (8)

This ticket was mentioned in ​PR #3889 on ​WordPress/wordpress-develop by ​@Mamaduka.
4 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/57526

Related Gutenberg PR: ​https://github.com/WordPress/gutenberg/pull/46815

#2 @Mamaduka
4 years ago

  • Milestone Awaiting Review → 6.2

​@Mamaduka commented on ​PR #3889:
4 years ago #3

cc @hellofromtonya

#4 @hellofromTonya
4 years ago

  • Description modified (diff)
  • Keywords gutenberg-merge added
  • Owner set to hellofromTonya
  • Status new → reviewing
  • Summary Globals Styles Endpoint: Declare edit_css capability in links → Globals Styles Endpoint: Declare 'edit_css' capability in links
  • Version → 5.9

​@hellofromTonya commented on ​PR #3889:
4 years ago #5

Currently reviewing.

#6 @hellofromTonya
4 years ago

  • Keywords commit added

​PR 3889:

  • Confirmed this patch has the REST PHP code changes from the GB PR ✅
  • Timothy confirmed the URL is okay ✅
  • Tests included ✅

Ready for commit 👍 Prepping commit now.

#7 @hellofromTonya
4 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 55177:

REST API: Declare 'edit_css' capability in links within WP_REST_Global_Styles_Controller.

Updates the Global Styles endpoint to expose the 'edit_css' capability via action links.

References:

  • ​Gutenberg PR 46815 Part of an effort to hide custom CSS setting for users without 'edit_css' capability.

Follow-up to [52342], [52051].

Props mamaduka, dsas, glendaviesnz, mmtr86, talldanwp, timothyblynjacobs.
Fixes #57526.

Note: See TracTickets for help on using tickets.