Opened 23 months ago
Closed 22 months ago
#57535 closed enhancement (fixed)
Update/Audit NPM Dependencies for 6.2
Reported by: | desrosj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Attachments (1)
Change History (22)
#2
@
23 months ago
- Keywords changes-requested added
- Milestone changed from Awaiting Review to 6.2
Hi @naeemhaque,
Thanks for this patch! I have a few items of feedback.
- Could you create a GitHub pull request for this? Because this affects the various build processes, it's a good way to confirm there will be no unintended side effects. You can find some documentation about this in the Core Handbook.
- It seems that the version qualifiers (
~
,^
, etc.) were removed from the dependencies. If they were present previously, could you re-add them?
This ticket was mentioned in PR #3913 on WordPress/wordpress-develop by NaeemHaque.
23 months ago
#3
In 53113:
Updated some NPM dependencies to the latest versions.
This updates several NPM dependencies to the latest versions, including:
grunt-contrib-qunit
from~6.2.0
to~6.2.1
qunit
from~2.19.1
to~2.19.4
sass
from^1.55.0
to^1.57.1
sinon
from~14.0.1
to~14.0.2
sinon-test
from~3.1.4
to~3.1.5
uglify-js
from^3.17.3"
to^3.17.4
Trac ticket: https://core.trac.wordpress.org/ticket/57535
#4
@
23 months ago
Hi @desrosj
Thanks for your feedback.
Now I have created a GitHub pull request for this and also added version qualifiers(~
, ^
)
@mukesh27 commented on PR #3913:
23 months ago
#5
@desrosj Can you review when you get a moment?
23 months ago
#6
Thanks @NaeemHaque. The changes look good in the individual commits, but it seems the last commit on this PR created some problems. I'm not sure what's happening, but could you take a look and try to fix?
There's also now a merge conflict after https://core.trac.wordpress.org/changeset/55150.
NaeemHaque commented on PR #3913:
22 months ago
#7
Hello @desrosj, sorry for this created problem. I've tried to resolve it but didn't. This branch has some conflicts I think you can resolve when merging with the branch trunk. On the other hand, I can create e new branch and update all dependencies again.
Thank you.
This ticket was mentioned in PR #3968 on WordPress/wordpress-develop by @desrosj.
22 months ago
#8
A version of #3913 with a few tweaks and conflicts resolved.
Trac ticket: https://core.trac.wordpress.org/ticket/57535
22 months ago
#9
No worries @NaeemHaque! Thanks for working on this so far.
I've created #3968 to resolve those conflicts and push. In the future when you create a PR, there is an option to allow repository maintainers to push to you pull request branch. If you check that, then Core committers can push changes to your pull request!
NaeemHaque commented on PR #3913:
22 months ago
#14
Noted with thanks.
This ticket was mentioned in PR #4008 on WordPress/wordpress-develop by @desrosj.
22 months ago
#16
Trac ticket: https://core.trac.wordpress.org/ticket/57535.
#20
@
22 months ago
- Keywords dev-feedback added
@desrosj Myself and @mukesh27 are scrubbing these tickets ahead of 6.2 Beta 1 later today.
Is there anything left for this ticket in 6.2, or are you ready to close it and open the 6.3 version for next cycle? Thanks!
#21
@
22 months ago
- Keywords changes-requested dev-feedback removed
- Resolution set to fixed
- Status changed from assigned to closed
As of today, all of the related items for this ticket have been addressed. I'm going to close this out, but if there's a need to update dependencies before RC we can reopen.
Updated NPM Dependencies for 6.2