WordPress.org
Get WordPress

Make WordPress Core

Opened 19 years ago

Closed 18 years ago

#5756 closed defect (bug) (invalid)

Wrong JavaScript syntax in Categories widget (wp-includes/widgets.php)

Reported by: reppep Owned by:
Priority: normal Milestone:
Component: General Version: 2.3.2
Severity: normal Keywords:
Cc: Focuses:

Description

The Categories widget uses invalid JS for the pop-up menu.

[pico]$ diff -u widgets.php.orig widgets.php
--- widgets.php.orig 2008-02-02 21:40:48.000000000 -0800
+++ widgets.php 2008-02-02 21:41:12.000000000 -0800
@@ -630,7 +630,7 @@

wp_dropdown_categories($cat_args . '&show_option_none= ' . ('Select Category'));

?>


-<script lang='javascript'><!--
+<script type='text/javascript'><!--

var dropdown = document.getElementById("cat");
function onCatChange() {

if ( dropdown.options[dropdown.selectedIndex].value > 0 ) {

Change History (2)

#1 @reppep
19 years ago

Gnarf -- patch mis-wrapped:

[pico]$ diff -u widgets.php.orig widgets.php
--- widgets.php.orig	2008-02-02 21:40:48.000000000 -0800
+++ widgets.php	2008-02-02 21:41:12.000000000 -0800
@@ -630,7 +630,7 @@
 		wp_dropdown_categories($cat_args . '&show_option_none= ' . __('Select Category'));
 ?>
 
-<script lang='javascript'><!--
+<script type='text/javascript'><!--
     var dropdown = document.getElementById("cat");
     function onCatChange() {
 		if ( dropdown.options[dropdown.selectedIndex].value > 0 ) {

#2 @DD32
18 years ago

  • Milestone 2.9
  • Resolution → invalid
  • Status new → closed

Has been fixed in another ticket at some point.

Note: See TracTickets for help on using tickets.