Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#57563 closed defect (bug) (fixed)

Docs: Update PHPDocs for wp_get_global_stylesheet()

Reported by: oandregal's profile oandregal Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.2 Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords: has-patch gutenberg-merge commit
Focuses: docs Cc:

Description (last modified by hellofromTonya)

The PHPDocs for the wp_get_global_stylesheet() have gone stale, they no longer reflect the values that can be passed to the function.

See https://github.com/WordPress/gutenberg/pull/46817

Change History (9)

This ticket was mentioned in PR #3918 on WordPress/wordpress-develop by @oandregal.


15 months ago
#1

  • Keywords has-patch added

Trac ticket https://core.trac.wordpress.org/ticket/57563
Backports https://github.com/WordPress/gutenberg/pull/46817

Note that this PHPDoc comment does not include yet the custom-css as it was not backported.

@oandregal commented on PR #3918:


15 months ago
#2

Created a dedicated trac ticket for this one https://core.trac.wordpress.org/ticket/57563

@ntsekouras commented on PR #3918:


15 months ago
#3

I wonder if this could be part of https://github.com/WordPress/wordpress-develop/pull/3896/files#r1088070674 instead of its own PR. Or merge this one quick and rebase 3896. I'm fine with whatever work best for people.

I think it will be faster to merge this PR and rebase the other one afterwards, since it's still a draft.

#4 @ntsekouras
15 months ago

  • Summary changed from Update PHPDocs for wp_get_global_stylesheet to Backport: Update PHPDocs for wp_get_global_stylesheet

#5 @hellofromTonya
15 months ago

  • Component changed from General to Editor
  • Description modified (diff)
  • Focuses docs added
  • Keywords gutenberg-merge added
  • Milestone changed from Awaiting Review to 6.2
  • Owner set to hellofromTonya
  • Status changed from new to reviewing
  • Summary changed from Backport: Update PHPDocs for wp_get_global_stylesheet to Docs: Update PHPDocs for wp_get_global_stylesheet()

Adding gutenberg-merge keyword for tracking the backport/copying of Gutenberg into Core work.

Removing "Backport" from summary. Why? In Core, it means to commit changes to older WordPress versions in different branches.

Related #56792.

#6 @hellofromTonya
15 months ago

  • Version changed from trunk to 5.9

5.9.0 was when this function and its DocBlock waS introduced.

#7 @hellofromTonya
15 months ago

  • Keywords commit added

Marking PR 3918 for commit.

#8 @hellofromTonya
15 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55144:

Docs: Update $types param for wp_get_global_stylesheet().

In 6.1.0, the values the $types parameter accepts changed to include 'base-layout-styles'.

This commit updates the DocBlock to reflect this change and provide clear information of what the function will load if no types are passed to it.

Reference:

Follow-up to [54162], [52054].

Props oandregal, jorgefilipecosta , ntsekouras.
Fixes #57563.
See #56792.

@hellofromTonya commented on PR #3918:


15 months ago
#9

Committed via https://core.trac.wordpress.org/changeset/55144. Thanks for your contributions!

Note: See TracTickets for help on using tickets.