WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#57571 closed enhancement (fixed)

Replace `get_blog_details` with `get_site`

Reported by: spacedmonkey's profile spacedmonkey Owned by: spacedmonkey's profile spacedmonkey
Milestone: 6.3 Priority: normal
Severity: normal Version: 3.0
Component: Networks and Sites Keywords: good-first-bug has-patch commit early
Focuses: multisite Cc:

Description

Replace usage of get_blog_details with get_site. Currently there are 2 instances of get_blog_details usage in core these can easily be replaced with get_site

Change History (9)

#1 @spacedmonkey
3 years ago

Pinging @flixos90 for his thoughts.

#2 @flixos90
3 years ago

@spacedmonkey That sounds like a reasonable change to me.

We should make sure there are no unintended side effects though, potentially related to the concerns voiced in #40228.

#3 @spacedmonkey
3 years ago

@flixos90 If we merge this change and deprecated this function, then I don't think #40228 really matters anymore.

This ticket was mentioned in ​PR #4069 on ​WordPress/wordpress-develop by ​@kapilpaul.
3 years ago #4

  • Keywords has-patch added

Trac ticket: trac-57571

trac-57571: Replace get_blog_details with get_site

#5 @spacedmonkey
3 years ago

  • Keywords commit added

@flixos90 The two places that use in core, just return the current site. So do not pass params, so not an issue.

#6 @spacedmonkey
3 years ago

  • Keywords early added
  • Milestone changed from Future Release to 6.2

#7 @spacedmonkey
3 years ago

  • Milestone changed from 6.2 to 6.3

#8 @spacedmonkey
3 years ago

  • Owner set to spacedmonkey
  • Status changed from new to assigned

#9 @spacedmonkey
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 55515:

Networks and Sites: Replace get_blog_details with get_site.

Replace usage of the function get_blog_details with more lightweight get_site.

Props spacedmonkey, kapilpaul, flixos90.
Fixes #57571.

Note: See TracTickets for help on using tickets.