Opened 2 years ago
Last modified 12 days ago
#57577 new defect (bug)
Admin: Color schema is not applied correctly to beta labels in site editor
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Future Release | Priority: | normal |
| Severity: | minor | Version: | |
| Component: | Administration | Keywords: | has-patch has-test-info changes-requested |
| Focuses: | css | Cc: |
Description
When the color schema is not the default, the "beta" label assigned to Editor in the Appearance menu does not apply the correct background color.
When you mouse over "Appearance" in the top menu, the background color of the beta label disappears.
Attachments (8)
Change History (23)
This ticket was mentioned in PR #3938 on WordPress/wordpress-develop by @wildworks.
2 years ago
#1
- Keywords has-patch added
Trac ticket:
@wildworks commented on PR #3938:
2 years ago
#2
I have confirmed that the "beta" label has been removed.
https://core.trac.wordpress.org/changeset/55281
I would like to close this issue as it no longer occurs.
#3
@
2 years ago
I have confirmed that the BETA label has been removed.
https://core.trac.wordpress.org/changeset/55281
I would be happy to close the ticket as this issue no longer occurs.
#4
@
2 years ago
- Component changed from General to Administration
- Focuses css added
- Keywords 2nd-opinion added
The patch may still be appropriate for any plugins that add a similar note, such as WooCommerce.
#6
@
2 years ago
@sabernhardt
Thank you for the advice.
I also installed the WooCommerce plugin and changed the admin color scheme. I've confirmed that the patch applied the background color to the badge as expected. For this reason, I would like to reopen the PR.
@wildworks commented on PR #3938:
2 years ago
#7
Reopened based on [Reopened based on this comment. this comment].
#9
@
2 years ago
- Keywords has-testing-info added
Test Report
Environment
- OS: macOS 12.4
- Web Server: Nginx
- PHP: 7.4.33
- WordPress: 6.3-alpha-55505-src
- Browser: Chrome
- Theme: Twenty Twenty-two
Screenshots:
- Beta Removed from Appearance: https://prnt.sc/kGyjkMlziGGU
- Woocommerce Background Colour badge: https://prnt.sc/ky74vF-dJys9
Notes
- The Beta is now removed from the appearance tab
- In WooCommerce submenu, with the Ectoplasm scheme, the remaining task background color still remains
This ticket was mentioned in Slack in #core by chaion07. View the logs.
2 years ago
#11
@
2 years ago
- Keywords changes-requested added
I applied a patch and have run build, but the correct color scheme didn't apply to submenu of the currently active parent. Screenshots are above.
#12
@
2 years ago
Thank you all for the test.
I have looked again at the latest trunk to see what colors are expected when the color schema is changed and what the problem is now. I consider the following four to be unexpectable behaviors:
- The badge isn't colored when the top-level menu with the badge is active.
- The background color changes when the mouse hovers over a top-level menu that is not active.
- The badge on the submenu within the active top-level menu isn't colored.
- The badge on the submenu within inactive top-level menus isn't colored.
If these behaviors are not what was intended, is it ok to attempt to resolve these issues with this ticket?
@
2 years ago
The background color changes when the mouse hovers over a top-level menu that is not active.
#13
@
2 years ago
- Milestone changed from 6.3 to Future Release
- Severity changed from normal to minor
Because the patch is not ready yet, I recommend revisiting this later (it can be moved back to 6.3 if desired).
The beta label is removed from Core, and the WooCommerce numbers are correct in the Default color scheme. It still would be good to fix for other color schemes, but maybe not this late in the release cycle.
@wildworks commented on PR #3938:
2 years ago
#14
Update: Based on the results of this test of the core ticket, I have adjusted the badge colors to be the intended badge colors in various cases. The selector is fairly simple, but simply overrides the default following style.
With this change, I have removed the $menu-bubble-current-background variable, which is no longer used anywhere.
I also found a behavior where the background color changes when mousing over an inactive top-level menu if it is not the default theme. However, in this PR, I did not make any changes to the above behavior but focused on the correct badges to be displayed.
## Default Color Scheme
It should be no different than before.
https://github.com/WordPress/wordpress-develop/assets/54422211/996e927f-053e-40c4-adc3-ad445cb66b0a
## Extplasm Color Scheme
https://github.com/WordPress/wordpress-develop/assets/54422211/56b046be-9cec-48bc-a4e6-942f89e2c85d
## Ocean Color Scheme
https://github.com/WordPress/wordpress-develop/assets/54422211/6313cdcc-ba9a-469f-b1ad-da861ad624e7
beta label