Changes between Initial Version and Version 1 of Ticket #57580, comment 6
- Timestamp:
- 03/16/2023 12:20:30 AM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #57580, comment 6
initial v1 4 4 > In this specific report, PHP is reporting the type mismatch. The function expects a `string` type. Passing a non-string is doing it wrong. The fix should be in the plugins, not in Core. 5 5 6 Yeah, I agree we should not duplicate PHP notices. My thinking was more along the lines of trying to improve developer experience by providing a more comprehensible message where possible, as an extender may not always be a n experienced developer, and the PHP notice it may not always be clear in context, especially if the function is not called directly and the incorrect parameter is somewhere in the call stack.6 Yeah, I agree we should not duplicate PHP notices. My thinking was more along the lines of trying to improve developer experience by providing a more comprehensible message where possible, as an extender may not always be a seasoned developer, and the PHP notice it may not always be clear in context, especially if the function is not called directly and the incorrect parameter is somewhere in the call stack.