Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #57581, comment 6


Ignore:
Timestamp:
03/24/2023 09:32:30 AM (11 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #57581, comment 6

    initial v1  
    22> I agree we should not duplicate PHP notices. My thinking was more along the lines of trying to improve developer experience by providing a more comprehensible message where possible, as an extender may not always be a seasoned developer, and the PHP notice may not always be clear in context, especially if the function is not called directly and the incorrect parameter is somewhere in the call stack.
    33
    4 That said, there are pretty good arguments above that adding `_doing_it_wrong()` notices on a case-by-case basis may not be the preferable approach in the long run, so I'm fine with closing in favor of a more structural approach if that's the consensus here :)
     4That said, there are pretty good arguments above that adding `_doing_it_wrong()` notices on a case-by-case basis may not be the preferable solution in the long run, so I'm fine with closing in favor of a more structural approach if that's the consensus here :)