#57582 closed enhancement (fixed)
Introduce dimensions.minHeight block support
Reported by: | andrewserong | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch has-unit-tests gutenberg-merge commit |
Focuses: | Cc: |
Description
In the Gutenberg plugin, a minimum height block support feature was added, with support for both Group and Post Content blocks. It would be good to backport this feature for the WP 6.2 release. While the feature is spread across JS and PHP code, it should be possible to land most of the PHP implementation in advance of the JS packages update for core.
The original feature landed in Gutenberg across the following PRs:
Change History (8)
This ticket was mentioned in PR #3940 on WordPress/wordpress-develop by @andrewserong.
20 months ago
#1
- Keywords has-patch has-unit-tests added
#2
@
20 months ago
- Keywords gutenberg-merge added
- Milestone changed from Awaiting Review to 6.2
- Summary changed from Backport min-height block support feature for WordPress 6.2 to Introduce dimensions.minHeight block support
- Version trunk deleted
@hellofromTonya commented on PR #3940:
20 months ago
#3
Status: Currently reviewing and testing for commit consideration.
#4
@
20 months ago
- Owner set to hellofromTonya
- Status changed from new to reviewing
Self-assigning for review and commit.
#5
@
20 months ago
- Keywords commit added
- Confirmed the PHP changes from the GB PRs are here ✅
- Confirmed there's no BC issue for the removal of experimentalDimensions setting ✅
- Reviewed for coding standards ✅
- Tests are okay ✅
- It's been tested ✅
Marking for commit
.
@hellofromTonya commented on PR #3940:
20 months ago
#7
Committed via https://core.trac.wordpress.org/changeset/55175.
@andrewserong commented on PR #3940:
20 months ago
#8
Wonderful, thank you for landing this one, and for the extra discussion, I learn more with each of these PRs 🙂
This PR backports the minimum height block support feature's PHP changes from Gutenberg. Those changes were originally merged in the following PRs:
The opting-in of the block support for particular blocks, and UI support will land separately as part of the main JS package update for 6.2 — hopefully, this PHP change should be able to safely land in isolation.
Trac ticket: https://core.trac.wordpress.org/ticket/57582