Make WordPress Core

Opened 15 months ago

Closed 7 months ago

Last modified 6 months ago

#57590 closed enhancement (fixed)

Class attribute for register and lost password link on login page

Reported by: wparslan's profile wparslan Owned by: costdev's profile costdev
Milestone: 6.4 Priority: low
Severity: normal Version:
Component: Login and Registration Keywords: has-patch good-first-bug has-dev-note
Focuses: ui, css Cc:

Description

You were kind enough to add the register link's changeable text.
It would be very good if you could provide the attribute for the link in the footer on the login page.

It would be lovely to style them separately as they are dynamic based on the register option.

Attachments (2)

57590.patch (2.9 KB) - added by thomasplevy 15 months ago.
Adds CSS clasnames to the lost password, registrartion, and log in anchors on wp-login.php
57590.1.diff (2.9 KB) - added by costdev 7 months ago.
Use a wp-login- prefix for more specific class names.

Download all attachments as: .zip

Change History (19)

@thomasplevy
15 months ago

Adds CSS clasnames to the lost password, registrartion, and log in anchors on wp-login.php

#1 @thomasplevy
15 months ago

  • Keywords has-patch added; needs-patch removed

#2 @wparslan
15 months ago

They are very generic classes, @thomasplevy

#3 @wparslan
11 months ago

@SergeyBiryukov any updates on this one?
This is sitting still...

#4 @rajinsharwar
8 months ago

  • Milestone changed from Awaiting Review to 6.4
  • Priority changed from normal to low
  • Version 6.1.1 deleted

#5 @rajinsharwar
8 months ago

  • Keywords commit added
  • Owner set to rajinsharwar
  • Status changed from new to assigned

Looks good to me, putting this for commit.

#6 @audrasjb
8 months ago

  • Keywords changes-requested added; commit removed

Adding classes to the wp-login links may be useful indeed, but for consistency we should also have corresponding classes on the Register screen – wp-register.php.

#7 @audrasjb
8 months ago

  • Owner changed from rajinsharwar to audrasjb
  • Status changed from assigned to reviewing

#8 @oglekler
7 months ago

As far as I see, changes are requested. @thomasplevy, please address comment:6
We have 9 days before Beta 1, but this is a simple enough enhancement to get into trunk in time.

#9 @thomasplevy
7 months ago

@oglekler

In February I was in a position to make some contributions and I knew I wouldn't have much time long-term so I submitted a few small self-contained patches. I had intentions of keeping up with some regular contribution but those intentions dissipated as I filled my time up with other projects.

Even with the best intentions, which I'd like to have, I know I won't be able to find the time over the next week to submit another patch to address @audrasjb's feedback.

I feel that I did exactly what the bug report requested and while I agree with the expanded scope of being consistent between the login and registration pages I simply don't have the time to address that right now.

Please understand that I love WordPress and I'd like to have more availability to contribute but my life currently doesn't allow for it. I haven't touched my development environment for core contribution since sometime in March and since I am not regularly contributing I'll need to read through documentation again and refresh my memory on how to get everything setup to contribute a patch correctly. I'm a competent developer but what you say is a "simple enough enhancement" is probably at least 90-minutes of effort for me since I'll need to run through a refresher to get myself in the right position to actually write what will amount to 5 or 6 lines of actual code. It's very simple, yes, but it's not top of mind for me. I work with WordPress daily but I don't work with SVN and Trac daily and I don't work with the development source of WordPress daily.

Thanks,

#10 @oglekler
7 months ago

  • Keywords good-first-bug added

@thomasplevy thank you for your contribution and the prompt feedback, possibly someone else will be able to pick up this work and move it through the finish line. No pressure, we all volunteers and doing our best to keep up with many different things in life.

I am marking this ticket as good first bug, as now the scope of what is left is quite straight forward.

This ticket was mentioned in Slack in #core by marybaum. View the logs.


7 months ago

#12 @marybaum
7 months ago

@costdev has volunteered to take this patch on and add the css class in wp-register. And then, perhaps, it'll be ready!

#13 @costdev
7 months ago

  • Focuses coding-standards removed
  • Owner changed from audrasjb to costdev
  • Status changed from reviewing to accepted

I'll take ownership of this ticket as JB currently has limited availability as we approach 6.4 Beta 1.

Last edited 7 months ago by costdev (previous) (diff)

@costdev
7 months ago

Use a wp-login- prefix for more specific class names.

#14 @costdev
7 months ago

  • Keywords changes-requested removed

for consistency we should also have corresponding classes on the Register screen – wp-register.php.
comment:6

wp-register.php was removed from the repository in [20596].

This file will still be there for sites that existed since before WordPress 3.4, but as it no longer exists in the repository, there is no file available for us to patch.

I agree with earlier feedback provided in comment:2 that .log-in, .register and .lost-password should be more specific. Those classes are likely to be used in existing frontend CSS, which may be loaded into the login screen as well.

57590.1.diff adds a wp-login- prefix to the classes to make them more specific, producing .wp-login-log-in, .wp-login-register and .wp-login-lost-password.

For transparency: I also discussed this ticket with @joedolson in Slack, who shared the opinion that the class names should be more specific.

Last edited 7 months ago by costdev (previous) (diff)

#15 @joedolson
7 months ago

  • Keywords commit added

Looks good to me!

#16 @costdev
7 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56628:

Login and Registration: Introduce classes wp-login.php footer links.

This introduces classes for the "Log in", "Register" and "Lost your password?" links in the footer of wp-login.php forms so that they may be easily targeted for individual styling.

The new classes are:

  • .wp-login-log-in
  • .wp-login-register
  • .wp-login-lost-password

Props wparslan, thomasplevy, rajinsharwar, audrasjb, joedolson, costdev.
Fixes #57590.

Note: See TracTickets for help on using tickets.