Class attribute for register and lost password link on login page

[wparslan]

You were kind enough to add the register link's changeable text.
It would be very good if you could provide the attribute for the link in the footer on the login page.

It would be lovely to style them separately as they are dynamic based on the register option.

[thomasplevy]

Adds CSS clasnames to the lost password, registrartion, and log in anchors on wp-login.php

[wparslan]

They are very generic classes, @thomasplevy

[wparslan]

@SergeyBiryukov any updates on this one?
This is sitting still...

[rajinsharwar]

Looks good to me, putting this for commit.

[audrasjb]

Adding classes to the wp-login links may be useful indeed, but for consistency we should also have corresponding classes on the Register screen – wp-register.php.

[oglekler]

As far as I see, changes are requested. @thomasplevy, please address comment:6
We have 9 days before Beta 1, but this is a simple enough enhancement to get into trunk in time.

[thomasplevy]

@oglekler

In February I was in a position to make some contributions and I knew I wouldn't have much time long-term so I submitted a few small self-contained patches. I had intentions of keeping up with some regular contribution but those intentions dissipated as I filled my time up with other projects.

Even with the best intentions, which I'd like to have, I know I won't be able to find the time over the next week to submit another patch to address @audrasjb's feedback.

I feel that I did exactly what the bug report requested and while I agree with the expanded scope of being consistent between the login and registration pages I simply don't have the time to address that right now.

Please understand that I love WordPress and I'd like to have more availability to contribute but my life currently doesn't allow for it. I haven't touched my development environment for core contribution since sometime in March and since I am not regularly contributing I'll need to read through documentation again and refresh my memory on how to get everything setup to contribute a patch correctly. I'm a competent developer but what you say is a "simple enough enhancement" is probably at least 90-minutes of effort for me since I'll need to run through a refresher to get myself in the right position to actually write what will amount to 5 or 6 lines of actual code. It's very simple, yes, but it's not top of mind for me. I work with WordPress daily but I don't work with SVN and Trac daily and I don't work with the development source of WordPress daily.

Thanks,

[oglekler]

@thomasplevy thank you for your contribution and the prompt feedback, possibly someone else will be able to pick up this work and move it through the finish line. No pressure, we all volunteers and doing our best to keep up with many different things in life.

I am marking this ticket as good first bug, as now the scope of what is left is quite straight forward.

[marybaum]

@costdev has volunteered to take this patch on and add the css class in wp-register. And then, perhaps, it'll be ready!

[costdev]

I'll take ownership of this ticket as JB currently has limited availability as we approach 6.4 Beta 1.

[costdev]

Use a wp-login- prefix for more specific class names.

[costdev]

for consistency we should also have corresponding classes on the Register screen – wp-register.php.
comment:6

wp-register.php was removed from the repository in [20596].

This file will still be there for sites that existed since before WordPress 3.4, but as it no longer exists in the repository, there is no file available for us to patch.

I agree with earlier feedback provided in comment:2 that .log-in, .register and .lost-password should be more specific. Those classes are likely to be used in existing frontend CSS, which may be loaded into the login screen as well.

57590.1.diff adds a wp-login- prefix to the classes to make them more specific, producing .wp-login-log-in, .wp-login-register and .wp-login-lost-password.

For transparency: I also discussed this ticket with @joedolson in Slack, who shared the opinion that the class names should be more specific.

[joedolson]

Looks good to me!

[costdev]

In 56628:

Login and Registration: Introduce classes wp-login.php footer links.

This introduces classes for the "Log in", "Register" and "Lost your password?" links in the footer of wp-login.php forms so that they may be easily targeted for individual styling.

The new classes are:

• .wp-login-log-in
• .wp-login-register
• .wp-login-lost-password

Props wparslan, thomasplevy, rajinsharwar, audrasjb, joedolson, costdev.
Fixes #57590.

[sabernhardt]

Dev note:
​https://make.wordpress.org/core/2023/10/17/html-markup-improvements-to-the-login-and-registration-page/