WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #57590, comment 14


Ignore:
Timestamp:
09/19/2023 10:27:39 PM (12 months ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #57590, comment 14

    initial v1  
    77
    88
    9 I agree with earlier feedback provided in [https://core.trac.wordpress.org/ticket/57590#comment:2 comment:2] that `.log-in`, `.register` and `.lost-password` are too generic for this screen. Those classes are likely to be used in existing frontend CSS, which may be loaded into the login screen as well.
     9I agree with earlier feedback provided in [https://core.trac.wordpress.org/ticket/57590#comment:2 comment:2] that `.log-in`, `.register` and `.lost-password` should be more specific. Those classes are likely to be used in existing frontend CSS, which may be loaded into the login screen as well.
    1010
    11 [https://core.trac.wordpress.org/attachment/ticket/57590/57590.1.diff 57590.1.diff] adds a `wp-login-` prefix to the classes to make them less generic, producing `.wp-login-log-in`, `.wp-login-register` and `.wp-login-lost-password`.
     11[https://core.trac.wordpress.org/attachment/ticket/57590/57590.1.diff 57590.1.diff] adds a `wp-login-` prefix to the classes to make them more specific, producing `.wp-login-log-in`, `.wp-login-register` and `.wp-login-lost-password`.
     12
     13For transparency: I also discussed this ticket with @joedolson in Slack, who shared the opinion that the class names should be more specific.